third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 2734173002: postMessage(): transfer allocation costs along with value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2734173002: postMessage(): transfer allocation costs along with value. (Closed)

Patch Set: rebased upto r455878 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index c9bcc0472ff271edc9bce2bebaa0473765ea6e40..ed8330b9afa2e06f0994c9db8bec9ea4161ab45c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -284,8 +284,9 @@ void V8Window::postMessageMethodCustom(

if (exceptionState.hadException())

return;

- window->postMessage(message.release(), transferables.messagePorts,

- targetOrigin, source, exceptionState);

+ window->postMessage(message.get(), transferables.messagePorts, targetOrigin,

+ source, exceptionState);

+ message->unregisterMemoryAllocatedByCurrentScriptContext();

}

void V8Window::openMethodCustom(