Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2734133003: Fix new service tests on windows; make status file more precise. (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix new service tests on windows; make status file more precise. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/8e2bf308c1712abbacb62e663d02a66e37d46481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M runtime/observatory/tests/service/next_through_simple_async_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 9 months ago (2017-03-07 12:38:05 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 9 months ago (2017-03-07 12:46:06 UTC) #3
jensj
3 years, 9 months ago (2017-03-07 12:49:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e2bf308c1712abbacb62e663d02a66e37d46481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698