runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart - Issue 2734133003: Fix new service tests on windows; make status file more precise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart

Issue 2734133003: Fix new service tests on windows; make status file more precise. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/next_through_simple_async_test.dart ('k') | runtime/observatory/tests/service/service.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart

diff --git a/runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart b/runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart

index a55a31c0854af382f89dacdcb645c7624284bd26..e13734566d14bd01a0e2aa48fbc5e5beaa8b4a33 100644

--- a/runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart

+++ b/runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart

@@ -11,7 +11,7 @@ const String file = "next_through_simple_async_with_returns_test.dart";

// line A is at the "code() async" line

code() async {

- File f = new File(Platform.script.path);

+ File f = new File(Platform.script.toFilePath());

bool exists = await f.exists();

if (exists) {

return 42;

@@ -27,7 +27,7 @@ List<String> stops = [];

List<String> expected = [

"$file:${LINE_A+0}:5", // on '(' in 'code()'

"$file:${LINE_A+1}:30", // on 'script'

- "$file:${LINE_A+1}:37", // on 'path'

+ "$file:${LINE_A+1}:37", // on 'toFilePath'

"$file:${LINE_A+1}:16", // on 'File'

"$file:${LINE_A+2}:25", // on 'exists'

"$file:${LINE_A+2}:17", // on 'await'