Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: runtime/observatory/tests/service/service.status

Issue 2734133003: Fix new service tests on windows; make status file more precise. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/service.status
diff --git a/runtime/observatory/tests/service/service.status b/runtime/observatory/tests/service/service.status
index 09248a4d8a3eeda002f6328a4fbccacce759ecd1..1b4451a9e53a18b2648726c5caa0b1ba577fcfda 100644
--- a/runtime/observatory/tests/service/service.status
+++ b/runtime/observatory/tests/service/service.status
@@ -10,14 +10,6 @@ pause_on_start_and_exit_test: Pass, RuntimeError # Issue 28624
pause_on_start_then_step_test: Pass, RuntimeError # Issue 28624
isolate_lifecycle_test: Pass, RuntimeError # Issue 24174
field_script_test: Pass, RuntimeError
-next_through_for_each_loop_test: Pass, RuntimeError
-next_through_create_list_and_map_test: Pass, RuntimeError
-next_through_closure_test: Pass, RuntimeError
-next_through_for_loop_with_break_and_continue_test: Pass, RuntimeError
-next_through_simple_async_test: Pass, RuntimeError
-next_through_simple_async_with_returns_test: Pass, RuntimeError
-next_through_catch_test: Pass, RuntimeError
-next_through_simple_linear_2_test: Pass, RuntimeError
[$runtime == vm && $compiler == none && $system == fuchsia]
*: Skip # Not yet triaged.
@@ -75,6 +67,13 @@ vm_restart_test: CompileTimeError # Issue 27806
debugger_location_second_test: Skip # Issue 28180
+# Snapshots doesn't include source and generated source is not 1-to-1.
+# The column offsets are thus off.
+next_through_for_each_loop_test: RuntimeError
+next_through_for_loop_with_break_and_continue_test: RuntimeError
+next_through_create_list_and_map_test: RuntimeError
+next_through_closure_test: RuntimeError
+
[ $compiler == dart2analyzer ]
evaluate_activation_in_method_class_test: CompileTimeError # Issue 24478
@@ -85,6 +84,11 @@ implicit_getter_setter_test: RuntimeError # Field guards unimplemented.
rewind_test: RuntimeError # Issue 27878
rewind_optimized_out_test: RuntimeError # Issue 27878
+# Debugging StringConcatenation doesn't work the same on simdbc as on other platforms.
+next_through_catch_test: RuntimeError
+next_through_simple_async_test: RuntimeError
+next_through_simple_linear_2_test: RuntimeError
+
[ $hot_reload || $hot_reload_rollback ]
# Skip all service tests because random reloads interfere.
*: SkipByDesign # The service tests should run without being reloaded.
« no previous file with comments | « runtime/observatory/tests/service/next_through_simple_async_with_returns_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698