Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2733993002:
Make WebFrameTest cope with idle time spell checker (Closed)
DescriptionMake WebFrameTest cope with idle time spell checker
This patch modifies spellchecking-related WebFrameTest:
- Page size is set, so that the editable element is made visible
- Idle time spell checker is forced to run after editing operation
so that these unit tests can pass.
It also removes a leftover from SpellcheckResultsSavedInDocument.
BUG=517298
Review-Url: https://codereview.chromium.org/2733993002
Cr-Commit-Position: refs/heads/master@{#455319}
Committed: https://chromium.googlesource.com/chromium/src/+/e72cd03ddb132b80e770939f048f3f80684d2362
Patch Set 1 #Patch Set 2 : Make WebFrameTest cope with idle time spell checker #
Depends on Patchset: Messages
Total messages: 25 (19 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make WebFrameTest cope with idle time spell checker BUG=517298 ========== to ========== Make WebFrameTest cope with idle time spell checker This patch modifies spellchecking-related WebFrameTest: - Page size is set, so that the editable element is made visible - Idle time spell checker is forced to run after editing operation so that these unit tests can pass. It also removes a leftover from SpellcheckResultsSavedInDocument. BUG=517298 ==========
xiaochengh@chromium.org changed reviewers: + tkent@chromium.org
PTAL.
lgtm
The CQ bit was unchecked by xiaochengh@chromium.org
The CQ bit was checked by xiaochengh@chromium.org
Thanks for the review!
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2720193002 Patch 140001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2733993002/#ps20001 (title: "Make WebFrameTest cope with idle time spell checker")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488935179056230,
"parent_rev": "fea9ebc8a336166c3c130aa00fa64a72d55d9bec", "commit_rev":
"e72cd03ddb132b80e770939f048f3f80684d2362"}
Message was sent while issue was closed.
Description was changed from ========== Make WebFrameTest cope with idle time spell checker This patch modifies spellchecking-related WebFrameTest: - Page size is set, so that the editable element is made visible - Idle time spell checker is forced to run after editing operation so that these unit tests can pass. It also removes a leftover from SpellcheckResultsSavedInDocument. BUG=517298 ========== to ========== Make WebFrameTest cope with idle time spell checker This patch modifies spellchecking-related WebFrameTest: - Page size is set, so that the editable element is made visible - Idle time spell checker is forced to run after editing operation so that these unit tests can pass. It also removes a leftover from SpellcheckResultsSavedInDocument. BUG=517298 Review-Url: https://codereview.chromium.org/2733993002 Cr-Commit-Position: refs/heads/master@{#455319} Committed: https://chromium.googlesource.com/chromium/src/+/e72cd03ddb132b80e770939f048f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e72cd03ddb132b80e770939f048f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
