Make WebFrameTest cope with idle time spell checker

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 #include "core/dom/Document.h"
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/NodeComputedStyle.h"
 #include "core/dom/Range.h"
 #include "core/editing/Editor.h"
 #include "core/editing/EphemeralRange.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/VisiblePosition.h"
 #include "core/editing/markers/DocumentMarkerController.h"
+#include "core/editing/spellcheck/IdleSpellCheckCallback.h"
 #include "core/editing/spellcheck/SpellChecker.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/frame/Settings.h"
 #include "core/frame/VisualViewport.h"
 #include "core/html/HTMLBodyElement.h"
 #include "core/html/HTMLFormElement.h"
@@ skipping 6202 matching lines @@
   }
   int numberOfTimesChecked() const { return m_numberOfTimesChecked; }
 
  private:
   int m_numberOfTimesChecked;
 };
 
 TEST_P(ParameterizedWebFrameTest, ReplaceMisspelledRange) {
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
-  webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+  initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
   SpellCheckClient spellcheck;
   webViewHelper.webView()->setSpellCheckClient(&spellcheck);
 
   WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
   Document* document = frame->frame()->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   NonThrowableExceptionState exceptionState;
   document->execCommand("InsertText", false, "_wellcome_.", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
+    document->frame()
+        ->spellChecker()
+        .idleSpellCheckCallback()
+        .forceInvocationForTesting();
+  }
+
   const int allTextBeginOffset = 0;
   const int allTextLength = 11;
   frame->selectRange(WebRange(allTextBeginOffset, allTextLength));
   EphemeralRange selectionRange =
       frame->frame()
           ->selection()
           .computeVisibleSelectionInDOMTreeDeprecated()
           .toNormalizedEphemeralRange();
 
   EXPECT_EQ(1, spellcheck.numberOfTimesChecked());
   EXPECT_EQ(1U, document->markers()
                     .markersInRange(selectionRange, DocumentMarker::Spelling)
                     .size());
 
   frame->replaceMisspelledRange("welcome");
   EXPECT_EQ("_welcome_.",
             WebFrameContentDumper::dumpWebViewAsText(
                 webViewHelper.webView(), std::numeric_limits<size_t>::max())
                 .utf8());
 }
 
 TEST_P(ParameterizedWebFrameTest, RemoveSpellingMarkers) {
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
-  webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+  initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
   SpellCheckClient spellcheck;
   webViewHelper.webView()->setSpellCheckClient(&spellcheck);
 
   WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
   Document* document = frame->frame()->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   NonThrowableExceptionState exceptionState;
   document->execCommand("InsertText", false, "_wellcome_.", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
+    document->frame()
+        ->spellChecker()
+        .idleSpellCheckCallback()
+        .forceInvocationForTesting();
+  }
+
   frame->removeSpellingMarkers();
 
   const int allTextBeginOffset = 0;
   const int allTextLength = 11;
   frame->selectRange(WebRange(allTextBeginOffset, allTextLength));
   EphemeralRange selectionRange =
       frame->frame()
           ->selection()
           .computeVisibleSelectionInDOMTreeDeprecated()
           .toNormalizedEphemeralRange();
 
   EXPECT_EQ(0U, document->markers()
                     .markersInRange(selectionRange, DocumentMarker::Spelling)
                     .size());
 }
 
 TEST_P(ParameterizedWebFrameTest, RemoveSpellingMarkersUnderWords) {
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
-  webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+  initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
   SpellCheckClient spellcheck;
   webViewHelper.webView()->setSpellCheckClient(&spellcheck);
 
   LocalFrame* frame = webViewHelper.webView()->mainFrameImpl()->frame();
   Document* document = frame->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   NonThrowableExceptionState exceptionState;
   document->execCommand("InsertText", false, " wellcome ", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
+    frame->spellChecker().idleSpellCheckCallback().forceInvocationForTesting();
+
   WebVector<unsigned> offsets1;
   webViewHelper.webView()->spellingMarkerOffsetsForTest(&offsets1);
   EXPECT_EQ(1U, offsets1.size());
 
   Vector<String> words;
   words.push_back("wellcome");
   frame->removeSpellingMarkersUnderWords(words);
 
   WebVector<unsigned> offsets2;
   webViewHelper.webView()->spellingMarkerOffsetsForTest(&offsets2);
@@ skipping 37 matching lines @@
     m_completion->didFinishCheckingText(results);
     m_completion = 0;
   }
 
   WebTextCheckingCompletion* m_completion;
 };
 
 TEST_P(ParameterizedWebFrameTest, SlowSpellcheckMarkerPosition) {
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
-  webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+  initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
 
   StubbornSpellCheckClient spellcheck;
   webViewHelper.webView()->setSpellCheckClient(&spellcheck);
 
   WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
   Document* document = frame->frame()->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   NonThrowableExceptionState exceptionState;
   document->execCommand("InsertText", false, "wellcome ", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
   document->execCommand("InsertText", false, "he", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
+    document->frame()
+        ->spellChecker()
+        .idleSpellCheckCallback()
+        .forceInvocationForTesting();
+  }
+
   spellcheck.kick();
 
   WebVector<unsigned> offsets;
   webViewHelper.webView()->spellingMarkerOffsetsForTest(&offsets);
   EXPECT_EQ(0U, offsets.size());
 }
 
 // This test verifies that cancelling spelling request does not cause a
 // write-after-free when there's no spellcheck client set.
 TEST_P(ParameterizedWebFrameTest, CancelSpellingRequestCrash) {
+  // The relevant code paths are obsolete with idle time spell checker.
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
+    return;
+
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
   webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
   webViewHelper.webView()->setSpellCheckClient(0);
 
   WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
   Document* document = frame->frame()->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   frame->frame()->editor().replaceSelectionWithText(
       "A", false, false, InputEvent::InputType::InsertReplacementText);
   frame->frame()->spellChecker().cancelCheck();
 }
 
 TEST_P(ParameterizedWebFrameTest, SpellcheckResultErasesMarkers) {
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
-  webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+  initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
 
   StubbornSpellCheckClient spellcheck;
   webViewHelper.webView()->setSpellCheckClient(&spellcheck);
 
   WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
   Document* document = frame->frame()->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   NonThrowableExceptionState exceptionState;
   document->execCommand("InsertText", false, "welcome ", exceptionState);
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
+    document->frame()
+        ->spellChecker()
+        .idleSpellCheckCallback()
+        .forceInvocationForTesting();
+  }
+
   document->updateStyleAndLayout();
 
   EXPECT_FALSE(exceptionState.hadException());
   auto range = EphemeralRange::rangeOfContents(*element);
   document->markers().addMarker(range.startPosition(), range.endPosition(),
                                 DocumentMarker::Spelling);
   document->markers().addMarker(range.startPosition(), range.endPosition(),
                                 DocumentMarker::Grammar);
   EXPECT_EQ(2U, document->markers().markers().size());
 
   spellcheck.kickNoResults();
   EXPECT_EQ(0U, document->markers().markers().size());
 }
 
 TEST_P(ParameterizedWebFrameTest, SpellcheckResultsSavedInDocument) {
   registerMockedHttpURLLoad("spell.html");
   FrameTestHelpers::WebViewHelper webViewHelper;
-  webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
+  initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
 
   StubbornSpellCheckClient spellcheck;
   webViewHelper.webView()->setSpellCheckClient(&spellcheck);
 
   WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
   Document* document = frame->frame()->document();
   Element* element = document->getElementById("data");
 
   webViewHelper.webView()->settings()->setEditingBehavior(
       WebSettings::EditingBehaviorWin);
 
   element->focus();
   NonThrowableExceptionState exceptionState;
   document->execCommand("InsertText", false, "wellcome ", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
+    document->frame()
+        ->spellChecker()
+        .idleSpellCheckCallback()
+        .forceInvocationForTesting();
+  }
+
   spellcheck.kick();
   ASSERT_EQ(1U, document->markers().markers().size());
   ASSERT_NE(static_cast<DocumentMarker*>(0), document->markers().markers()[0]);
   EXPECT_EQ(DocumentMarker::Spelling, document->markers().markers()[0]->type());
 
   document->execCommand("InsertText", false, "wellcome ", exceptionState);
   EXPECT_FALSE(exceptionState.hadException());
 
+  if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
+    document->frame()
+        ->spellChecker()
+        .idleSpellCheckCallback()
+        .forceInvocationForTesting();
+  }
+
   spellcheck.kickGrammar();
   ASSERT_EQ(1U, document->markers().markers().size());
   ASSERT_NE(static_cast<DocumentMarker*>(0), document->markers().markers()[0]);
   EXPECT_EQ(DocumentMarker::Grammar, document->markers().markers()[0]->type());
-
-  document->execCommand("InsertText", false, "wellcome ", exceptionState);
-  EXPECT_FALSE(exceptionState.hadException());
 }
 
 class TestAccessInitialDocumentWebFrameClient
     : public FrameTestHelpers::TestWebFrameClient {
  public:
   TestAccessInitialDocumentWebFrameClient()
       : m_didAccessInitialDocument(false) {}
 
   virtual void didAccessInitialDocument() { m_didAccessInitialDocument = true; }
 
@@ skipping 4810 matching lines @@
   FrameTestHelpers::WebViewHelper openerHelper;
   openerHelper.initialize(false, nullptr, &openerWebViewClient);
   FrameTestHelpers::WebViewHelper helper;
   helper.initializeWithOpener(openerHelper.webView()->mainFrame());
 
   openerHelper.reset();
   EXPECT_EQ(nullptr, helper.webView()->mainFrameImpl()->opener());
 }
 
 }  // namespace blink