Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2733943002: Trim whitespace from Referrer-Policy tokens (Closed)

Created:
3 years, 9 months ago by estark
Modified:
3 years, 9 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim whitespace from Referrer-Policy tokens This will allow Chrome to accept headers such as the following: Referrer-Policy: origin, no-referrer which would previously result in a RP of 'origin', since " no-referrer" would match any valid policy. BUG=698813 TEST=https://github.com/w3c/web-platform-tests/pull/5054 Review-Url: https://codereview.chromium.org/2733943002 Cr-Commit-Position: refs/heads/master@{#455331} Committed: https://chromium.googlesource.com/chromium/src/+/0573ada970c3acde0fcc51bf5f7a5c9be9e7629c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
estark
jochen, PTAL? (And does this seem like the correct behavior to you?)
3 years, 9 months ago (2017-03-06 20:10:42 UTC) #4
jochen (gone - plz use gerrit)
I think if you add the WPT to this CL, they'll automatically will be upstreamed ...
3 years, 9 months ago (2017-03-07 08:20:10 UTC) #7
estark
On 2017/03/07 08:20:10, jochen wrote: > I think if you add the WPT to this ...
3 years, 9 months ago (2017-03-07 23:28:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733943002/1
3 years, 9 months ago (2017-03-07 23:29:52 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:45:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0573ada970c3acde0fcc51bf5f7a...

Powered by Google App Engine
This is Rietveld 408576698