|
|
Created:
3 years, 9 months ago by estark Modified:
3 years, 9 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
blink-reviews, chromium-reviews, kinuko+watch Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTrim whitespace from Referrer-Policy tokens
This will allow Chrome to accept headers such as the following:
Referrer-Policy: origin, no-referrer
which would previously result in a RP of 'origin', since " no-referrer" would
match any valid policy.
BUG=698813
TEST=https://github.com/w3c/web-platform-tests/pull/5054
Review-Url: https://codereview.chromium.org/2733943002
Cr-Commit-Position: refs/heads/master@{#455331}
Committed: https://chromium.googlesource.com/chromium/src/+/0573ada970c3acde0fcc51bf5f7a5c9be9e7629c
Patch Set 1 #
Created: 3 years, 9 months ago
Messages
Total messages: 15 (10 generated)
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
estark@chromium.org changed reviewers: + jochen@chromium.org
jochen, PTAL? (And does this seem like the correct behavior to you?)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
I think if you add the WPT to this CL, they'll automatically will be upstreamed otherwise, lgtm
On 2017/03/07 08:20:10, jochen wrote: > I think if you add the WPT to this CL, they'll automatically will be upstreamed Oh, cool! Since I already sent the PR to WPT with a test for this in addition to some other tests, I'm guessing in this case it might be simplest to let that get merged and then pulled downstream, rather than add the test both upstream and downstream. Next time I'll start adding WPTs directly to my CLs though. > > otherwise, lgtm
Description was changed from ========== Trim whitespace from Referrer-Policy tokens This will allow Chrome to accept headers such as the following: Referrer-Policy: origin, no-referrer which would previously result in a RP of 'origin', since " no-referrer" would match any valid policy. BUG=698813 TEST=I'm writing a web-platform-test which will live in referrer-policy/generic/multiple-headers-combined.html. ========== to ========== Trim whitespace from Referrer-Policy tokens This will allow Chrome to accept headers such as the following: Referrer-Policy: origin, no-referrer which would previously result in a RP of 'origin', since " no-referrer" would match any valid policy. BUG=698813 TEST=https://github.com/w3c/web-platform-tests/pull/5054 ==========
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1488929343233240, "parent_rev": "f806d9cfee9133b9bf2fd1d79bbaaa42aec240e8", "commit_rev": "5536776ef00d7214705084fcfe2cc5cc8d06d734"}
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1488929343233240, "parent_rev": "04c65e9b0c773d0b3888634dd4cc9f01181a6820", "commit_rev": "0573ada970c3acde0fcc51bf5f7a5c9be9e7629c"}
Message was sent while issue was closed.
Description was changed from ========== Trim whitespace from Referrer-Policy tokens This will allow Chrome to accept headers such as the following: Referrer-Policy: origin, no-referrer which would previously result in a RP of 'origin', since " no-referrer" would match any valid policy. BUG=698813 TEST=https://github.com/w3c/web-platform-tests/pull/5054 ========== to ========== Trim whitespace from Referrer-Policy tokens This will allow Chrome to accept headers such as the following: Referrer-Policy: origin, no-referrer which would previously result in a RP of 'origin', since " no-referrer" would match any valid policy. BUG=698813 TEST=https://github.com/w3c/web-platform-tests/pull/5054 Review-Url: https://codereview.chromium.org/2733943002 Cr-Commit-Position: refs/heads/master@{#455331} Committed: https://chromium.googlesource.com/chromium/src/+/0573ada970c3acde0fcc51bf5f7a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0573ada970c3acde0fcc51bf5f7a... |