Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2733823004: Remove old permission delegation prototype (Closed)

Created:
3 years, 9 months ago by Timothy Loh
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-permissions_chromium.org, mlamouri+watch-blink_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old permission delegation prototype This patch removes the permission delegation prototype code, as we've decided to support this capability via Feature Policy instead and so the delegation logic will be implemented differently. BUG=614608 Review-Url: https://codereview.chromium.org/2733823004 Cr-Commit-Position: refs/heads/master@{#457317} Committed: https://chromium.googlesource.com/chromium/src/+/168b507a6d9c69a833e5ab1ce9ff59d15ebf309a

Patch Set 1 #

Patch Set 2 : update webexposed layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -719 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/permissions/delegation_tracker.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/permissions/delegation_tracker.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/permissions/delegation_tracker_unittest.cc View 1 chunk +0 lines, -227 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/frame_owner_properties.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/frame_owner_properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/frame_owner_properties.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/stable/webexposed/permissions-attribute-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/permissions-attribute-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameOwner.h View 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.h View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 5 chunks +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.idl View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/WebKit/Source/core/html/HTMLIFrameElementPermissionsTest.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElementTest.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.h View 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameOwnerProperties.h View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
Timothy Loh
3 years, 9 months ago (2017-03-08 04:57:24 UTC) #9
esprehn
All your webkit_tests seem to be failing? lgtm though, thanks for cleaning this up!
3 years, 9 months ago (2017-03-08 05:03:17 UTC) #11
raymes
lgtm
3 years, 9 months ago (2017-03-09 00:18:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733823004/20001
3 years, 9 months ago (2017-03-09 00:24:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/381480)
3 years, 9 months ago (2017-03-09 00:36:35 UTC) #16
Timothy Loh
+jochen for OWNERS for content/common and virtual/stable/webexposed (no change to stable, moved the expectation file ...
3 years, 9 months ago (2017-03-09 02:28:47 UTC) #18
jochen (gone - plz use gerrit)
can you help me understand whether this is a web-exposed change? Should this require an ...
3 years, 9 months ago (2017-03-09 10:41:00 UTC) #19
esprehn
On 2017/03/09 at 10:41:00, jochen wrote: > can you help me understand whether this is ...
3 years, 9 months ago (2017-03-09 12:34:07 UTC) #20
Timothy Loh
jochen@: ping :)
3 years, 9 months ago (2017-03-15 03:29:59 UTC) #21
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-15 15:49:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733823004/20001
3 years, 9 months ago (2017-03-15 23:49:00 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:22:48 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/168b507a6d9c69a833e5ab1ce9ff...

Powered by Google App Engine
This is Rietveld 408576698