Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 2733823004: Remove old permission delegation prototype (Closed)
Patch Set: update webexposed layout tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
index 90a0daed6f20f66ee4acd1b255aef936f7b606e8..a487c30277bc351c1200d22864f4ec7fe785a719 100644
--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
@@ -47,7 +47,6 @@ DEFINE_NODE_FACTORY(HTMLIFrameElement)
DEFINE_TRACE(HTMLIFrameElement) {
visitor->trace(m_sandbox);
- visitor->trace(m_permissions);
visitor->trace(m_allow);
HTMLFrameElementBase::trace(visitor);
Supplementable<HTMLIFrameElement>::trace(visitor);
@@ -59,12 +58,6 @@ DOMTokenList* HTMLIFrameElement::sandbox() const {
return m_sandbox.get();
}
-DOMTokenList* HTMLIFrameElement::permissions() const {
- if (!const_cast<HTMLIFrameElement*>(this)->initializePermissionsAttribute())
- return nullptr;
- return m_permissions.get();
-}
-
DOMTokenList* HTMLIFrameElement::allow() const {
return m_allow.get();
}
@@ -147,9 +140,6 @@ void HTMLIFrameElement::parseAttribute(
m_allowPaymentRequest = !value.isNull();
if (m_allowPaymentRequest != oldAllowPaymentRequest)
frameOwnerPropertiesChanged();
- } else if (name == permissionsAttr) {
- if (initializePermissionsAttribute())
- m_permissions->setValue(value);
} else if (RuntimeEnabledFeatures::embedderCSPEnforcementEnabled() &&
name == cspAttr) {
// TODO(amalika): add more robust validation of the value
@@ -202,21 +192,6 @@ bool HTMLIFrameElement::isInteractiveContent() const {
return true;
}
-void HTMLIFrameElement::permissionsValueWasSet() {
- if (!initializePermissionsAttribute())
- return;
-
- String invalidTokens;
- m_delegatedPermissions =
- m_permissions->parseDelegatedPermissions(invalidTokens);
- if (!invalidTokens.isNull())
- document().addConsoleMessage(ConsoleMessage::create(
- OtherMessageSource, ErrorMessageLevel,
- "Error while parsing the 'permissions' attribute: " + invalidTokens));
- setSynchronizedLazyAttribute(permissionsAttr, m_permissions->value());
- frameOwnerPropertiesChanged();
-}
-
void HTMLIFrameElement::sandboxValueWasSet() {
String invalidTokens;
setSandboxFlags(m_sandbox->value().isNull()
@@ -245,13 +220,4 @@ ReferrerPolicy HTMLIFrameElement::referrerPolicyAttribute() {
return m_referrerPolicy;
}
-bool HTMLIFrameElement::initializePermissionsAttribute() {
- if (!RuntimeEnabledFeatures::permissionDelegationEnabled())
- return false;
-
- if (!m_permissions)
- m_permissions = HTMLIFrameElementPermissions::create(this);
- return true;
-}
-
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLIFrameElement.h ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698