Get rid of FrameSelection::setSelection() taking VisibleSelection and SetSelectionOptions

Get rid of FrameSelection::setSelection() taking VisibleSelection and SetSelectionOptions

This patch gets rid of |FrameSelection::SetSelectionOptions()| taking
|VisibleSelection| and |SetSelectionOptions| since it is used only in one
call site to reduce source code size for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2733793002
Cr-Commit-Position: refs/heads/master@{#455019}
Committed: https://chromium.googlesource.com/chromium/src/+/cac6c252b97e579353f83be2d68253fba17c2524

[yosin_UTC9, 2017-03-06 07:48:49]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 07:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-06 08:12:59]

Description was changed from

==========
2017-03-06T16:47:26

2017-03-06T16:47:22

BUG=
==========

to

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection and
SetSelectionOptions

This patch gets rid of |FrameSelection::SetSelectionOptions()| taking
|VisibleSelection| and |SetSelectionOptions| since it is used only in one
call site to reduce source code size for improving code health.

BUG=698633
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-06 08:13:18]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-06 08:13:19]

PTAL

[commit-bot: I haz the power, 2017-03-06 09:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 09:09:07]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-03-06 18:56:52]

lgtm

[yosin_UTC9, 2017-03-07 01:17:25]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:18:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:27:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488849445374020, "parent_rev":
"08a8136e57f46ee167eef2ff3ffe2667a6ef0174", "commit_rev":
"cac6c252b97e579353f83be2d68253fba17c2524"}

[commit-bot: I haz the power, 2017-03-07 01:28:45]

Description was changed from

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection and
SetSelectionOptions

This patch gets rid of |FrameSelection::SetSelectionOptions()| taking
|VisibleSelection| and |SetSelectionOptions| since it is used only in one
call site to reduce source code size for improving code health.

BUG=698633
TEST=n/a; no behavior changes
==========

to

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection and
SetSelectionOptions

This patch gets rid of |FrameSelection::SetSelectionOptions()| taking
|VisibleSelection| and |SetSelectionOptions| since it is used only in one
call site to reduce source code size for improving code health.

BUG=698633
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2733793002
Cr-Commit-Position: refs/heads/master@{#455019}
Committed:
https://chromium.googlesource.com/chromium/src/+/cac6c252b97e579353f83be2d682...
==========

[commit-bot: I haz the power, 2017-03-07 01:28:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cac6c252b97e579353f83be2d682...