Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2733793002: Get rid of FrameSelection::setSelection() taking VisibleSelection and SetSelectionOptions (Closed)
Patch Set: 2017-03-06T16:47:26 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, 124 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
125 TextGranularity = CharacterGranularity); 125 TextGranularity = CharacterGranularity);
126 126
127 // TODO(yosin): We should use |SelectionInDOMTree| version instead of 127 // TODO(yosin): We should use |SelectionInDOMTree| version instead of
128 // |VisibleSelection| version. 128 // |VisibleSelection| version.
129 void setSelection(const VisibleSelection&, 129 void setSelection(const VisibleSelection&,
130 HandleVisibility = HandleVisibility::NotVisible, 130 HandleVisibility = HandleVisibility::NotVisible,
131 SetSelectionOptions = CloseTyping | ClearTypingStyle, 131 SetSelectionOptions = CloseTyping | ClearTypingStyle,
132 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, 132 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
133 TextGranularity = CharacterGranularity); 133 TextGranularity = CharacterGranularity);
134 void setSelection(const VisibleSelection&, SetSelectionOptions);
135 bool setSelectedRange( 134 bool setSelectedRange(
136 const EphemeralRange&, 135 const EphemeralRange&,
137 TextAffinity, 136 TextAffinity,
138 SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional, 137 SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional,
139 FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle); 138 FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle);
140 void selectAll(); 139 void selectAll();
141 void clear(); 140 void clear();
142 141
143 // TODO(tkent): These two functions were added to fix crbug.com/695211 without 142 // TODO(tkent): These two functions were added to fix crbug.com/695211 without
144 // changing focus behavior. Once we fix crbug.com/690272, we can remove these 143 // changing focus behavior. Once we fix crbug.com/690272, we can remove these
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 324
326 } // namespace blink 325 } // namespace blink
327 326
328 #ifndef NDEBUG 327 #ifndef NDEBUG
329 // Outside the WebCore namespace for ease of invocation from gdb. 328 // Outside the WebCore namespace for ease of invocation from gdb.
330 void showTree(const blink::FrameSelection&); 329 void showTree(const blink::FrameSelection&);
331 void showTree(const blink::FrameSelection*); 330 void showTree(const blink::FrameSelection*);
332 #endif 331 #endif
333 332
334 #endif // FrameSelection_h 333 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698