Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/debug/debug-interface.h

Issue 2733783002: [debug] change coverage API to use offset instead of line/column. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8.cc ('k') | src/inspector/js_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-interface.h
diff --git a/src/debug/debug-interface.h b/src/debug/debug-interface.h
index 387cce0662ada766f40f4099612ab11cdb9cbf23..bbd6f6ac7f1c9e037d0f9e0763e5d831dd65137b 100644
--- a/src/debug/debug-interface.h
+++ b/src/debug/debug-interface.h
@@ -218,17 +218,15 @@ class V8_EXPORT_PRIVATE Coverage {
class V8_EXPORT_PRIVATE FunctionData {
public:
- // 0-based line and colum numbers.
- Location Start() { return start_; }
- Location End() { return end_; }
+ int StartOffset();
+ int EndOffset();
uint32_t Count();
MaybeLocal<String> Name();
private:
- FunctionData(i::CoverageFunction* function, Local<debug::Script> script);
+ explicit FunctionData(i::CoverageFunction* function)
+ : function_(function) {}
i::CoverageFunction* function_;
- Location start_;
- Location end_;
friend class v8::debug::Coverage::ScriptData;
};
« no previous file with comments | « src/d8.cc ('k') | src/inspector/js_protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698