Fix the conditional operator's usage

Fix the conditional operator's usage

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). The second min() 
should be fixed to max().

This CL fixed this bug and added unittests.

BUG=697659
Review-Url: https://codereview.chromium.org/2733503002
Cr-Commit-Position: refs/heads/master@{#454763}
Committed: https://chromium.googlesource.com/chromium/src/+/76905b16d9f5ba9533a7e8d41724fcd383fa4d37

[chengx, 2017-03-03 00:24:00]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 00:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-03-03 00:44:41]

Description was changed from

==========
Fix nits.

BUG=697659
==========

to

==========
Remove the conditional expression as it is useless

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). This should be 
fixed.

BUG=697659
==========

[chengx, 2017-03-03 02:00:31]

chengx@chromium.org changed reviewers:
+ sky@chromium.org

[chengx, 2017-03-03 02:00:31]

PTAL~

[Avi (use Gerrit), 2017-03-03 02:03:43]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2017-03-03 02:03:44]

https://codereview.chromium.org/2733503002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/geometry/FloatQuad.cpp (left):

https://codereview.chromium.org/2733503002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/geometry/FloatQuad.cpp:85: :
std::numeric_limits<int>::min();
It seems likely that they meant

return std::signbit(value) ? std::numeric_limits<int>::min()
                               : std::numeric_limits<int>::max();

[chengx, 2017-03-03 02:15:28]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 02:15:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-03-03 02:20:53]

Description was changed from

==========
Remove the conditional expression as it is useless

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). This should be 
fixed.

BUG=697659
==========

to

==========
Fix the conditional operator's usage

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). 

The second min() should be fixed to max().

BUG=697659
==========

[commit-bot: I haz the power, 2017-03-03 03:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 03:34:50]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-03 04:08:34]

sky@chromium.org changed reviewers:
- sky@chromium.org

[sky, 2017-03-03 04:08:34]

I'm removing myself as a reviewer as I'm not an owner of this file.

[Avi (use Gerrit), 2017-03-03 04:24:19]

On 2017/03/03 04:08:34, sky wrote:
> I'm removing myself as a reviewer as I'm not an owner of this file.

I'm not an owner either, but I ran across this CL and it seemed wrong.

PS2 LGTM but you need to find an owner.

[chengx, 2017-03-03 04:36:58]

chengx@chromium.org changed reviewers:
+ pfeldman@chromium.org
- avi@chromium.org

[chengx, 2017-03-03 04:36:59]

Hi pfeldman@, codereview tool shows you are an owner of this file, but I am not
sure. If you are, PTAL~

[pfeldman, 2017-03-03 15:43:40]

pfeldman@chromium.org changed reviewers:
+ eae@chromium.org
- pfeldman@chromium.org

[pfeldman, 2017-03-03 15:44:27]

Fix is fine, but Emil should look at it to add a test.

[chengx, 2017-03-03 21:21:33]

FloatQuad.cpp seems not well covered by unittests, where more dev efforts are
needed.

For this CL, the bug is so obvious that I think maybe it is better to separate
it from the CLs adding the unittests (not necessarily only for the function
owning this bug), IMHO.

On 2017/03/03 15:44:27, pfeldman wrote:
> Fix is fine, but Emil should look at it to add a test.

[pdr., 2017-03-03 21:48:22]

On 2017/03/03 at 21:21:33, chengx wrote:
> FloatQuad.cpp seems not well covered by unittests, where more dev efforts are
needed.

Can you add a simple test to
third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp?

[chengx, 2017-03-03 23:30:13]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 23:30:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-03-04 00:52:11]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[chengx, 2017-03-04 00:52:34]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-03-04 00:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-03-04 01:35:43]

Description was changed from

==========
Fix the conditional operator's usage

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). 

The second min() should be fixed to max().

BUG=697659
==========

to

==========
Fix the conditional operator's usage

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). The second min() 
should be fixed to max().

This CL fixed this bug and added unittests.

BUG=697659
==========

[commit-bot: I haz the power, 2017-03-04 02:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 02:13:55]

Dry run: This issue passed the CQ dry run.

[eae, 2017-03-04 04:51:26]

LGTM, thank you!

[chengx, 2017-03-04 05:35:00]

The CQ bit was checked by chengx@chromium.org

[chengx, 2017-03-04 05:35:00]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2733503002/#ps60001
(title: "add unittests.")

[commit-bot: I haz the power, 2017-03-04 05:35:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 05:38:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488605700107800,
"parent_rev": "5cff667b54049eb1d52cb5fadac3e9ed08e68460", "commit_rev":
"76905b16d9f5ba9533a7e8d41724fcd383fa4d37"}

[commit-bot: I haz the power, 2017-03-04 05:39:28]

Description was changed from

==========
Fix the conditional operator's usage

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). The second min() 
should be fixed to max().

This CL fixed this bug and added unittests.

BUG=697659
==========

to

==========
Fix the conditional operator's usage

PVS-Studio pointed out that for the code touched in this CL, the '?:' 
operator, regardless of its conditional expression, always returns one 
and the same value: std::numeric_limits <int>::min(). The second min() 
should be fixed to max().

This CL fixed this bug and added unittests.

BUG=697659

Review-Url: https://codereview.chromium.org/2733503002
Cr-Commit-Position: refs/heads/master@{#454763}
Committed:
https://chromium.googlesource.com/chromium/src/+/76905b16d9f5ba9533a7e8d41724...
==========

[commit-bot: I haz the power, 2017-03-04 05:39:30]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/76905b16d9f5ba9533a7e8d41724...