Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp

Issue 2733503002: Fix the conditional operator's usage (Closed)
Patch Set: add unittests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/geometry/FloatQuad.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp b/third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp
index 9f918c85a94adca23ab7a6f3780e2879a9975c1d..d9cd4656b365e2651cd7595024b99bca37d26a46 100644
--- a/third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp
+++ b/third_party/WebKit/Source/platform/geometry/FloatQuadTest.cpp
@@ -4,6 +4,7 @@
#include "platform/geometry/FloatQuad.h"
+#include <limits>
#include "testing/gtest/include/gtest/gtest.h"
#include "wtf/text/WTFString.h"
@@ -15,4 +16,24 @@ TEST(FloatQuadTest, ToString) {
EXPECT_EQ("2,3; 5,7; 11,13; 17,19", quad.toString());
}
+TEST(FloatQuadTest, BoundingBox) {
+ FloatQuad quad(FloatPoint(2, 3), FloatPoint(5, 7), FloatPoint(11, 13),
+ FloatPoint(17, 19));
+ FloatRect rect = quad.boundingBox();
+ EXPECT_EQ(rect.x(), 2);
+ EXPECT_EQ(rect.y(), 3);
+ EXPECT_EQ(rect.width(), 17 - 2);
+ EXPECT_EQ(rect.height(), 19 - 3);
+}
+
+TEST(FloatQuadTest, BoundingBoxSaturateInf) {
+ double inf = std::numeric_limits<double>::infinity();
+ FloatQuad quad(FloatPoint(-inf, 3), FloatPoint(5, inf), FloatPoint(11, 13),
+ FloatPoint(17, 19));
+ FloatRect rect = quad.boundingBox();
+ EXPECT_EQ(rect.x(), std::numeric_limits<int>::min());
+ EXPECT_EQ(rect.y(), 3.0f);
+ EXPECT_EQ(rect.width(), 17.0f - std::numeric_limits<int>::min());
+ EXPECT_EQ(rect.height(), std::numeric_limits<int>::max() - 3.0f);
+}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/geometry/FloatQuad.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698