Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2733463003: [DevTools] Console should wait for the main target (Closed)

Created:
3 years, 9 months ago by eostroukhov
Modified:
3 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[DevTools] Console should wait for the main target BUG=694761 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2726933002 Cr-Commit-Position: refs/heads/master@{#454054} (cherry picked from commit 13edaa9f1b449a0de7fb6529c5227751668a4ec9) Review-Url: https://codereview.chromium.org/2733463003 Cr-Commit-Position: refs/branch-heads/2987@{#759} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 4 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733463003/1
3 years, 9 months ago (2017-03-03 23:05:26 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-03 23:05:28 UTC) #4
eostroukhov
Merge commit, owners approval needed.
3 years, 9 months ago (2017-03-03 23:07:01 UTC) #6
eostroukhov
3 years, 9 months ago (2017-03-03 23:07:24 UTC) #8
dgozman
lgtm
3 years, 9 months ago (2017-03-03 23:26:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733463003/1
3 years, 9 months ago (2017-03-03 23:43:07 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-03 23:43:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733463003/1
3 years, 9 months ago (2017-03-03 23:44:44 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 23:49:54 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/135dd9d1d83609b2a0c4c0458f9b...

Powered by Google App Engine
This is Rietveld 408576698