[DevTools] Console should wait for the main target

[DevTools] Console should wait for the main target

BUG=694761
Review-Url: https://codereview.chromium.org/2726933002
Cr-Commit-Position: refs/heads/master@{#454054}
Committed: https://chromium.googlesource.com/chromium/src/+/13edaa9f1b449a0de7fb6529c5227751668a4ec9

[eostroukhov, 2017-03-01 19:16:32]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 19:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-01 19:17:12]

eostroukhov@chromium.org changed reviewers:
+ dgozman@chromium.org, einbinder@chromium.org

[eostroukhov, 2017-03-01 19:17:12]

Please take a look.

[einbinder, 2017-03-01 20:15:45]

https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:211:
_initConsoleMessages() {
Maybe this should take mainTarget as an argument, so it doesn't need to do a
bunch of checks against mainTarget that should never be null.

[eostroukhov, 2017-03-01 20:22:56]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:23:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-01 20:23:31]

Please, take another look.

https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:211:
_initConsoleMessages() {
On 2017/03/01 20:15:45, einbinder wrote:
> Maybe this should take mainTarget as an argument, so it doesn't need to do a
> bunch of checks against mainTarget that should never be null.

Done.

[dgozman, 2017-03-01 20:28:47]

lgtm

[eostroukhov, 2017-03-01 20:31:11]

The CQ bit was unchecked by eostroukhov@chromium.org

[eostroukhov, 2017-03-01 20:31:15]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:00:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488400275203020,
"parent_rev": "66ae523c09fc27a92c7b972de8495f9723922ba1", "commit_rev":
"13edaa9f1b449a0de7fb6529c5227751668a4ec9"}

[commit-bot: I haz the power, 2017-03-01 22:01:03]

Description was changed from

==========
[DevTools] Console should wait for the main target

BUG=694761
==========

to

==========
[DevTools] Console should wait for the main target

BUG=694761

Review-Url: https://codereview.chromium.org/2726933002
Cr-Commit-Position: refs/heads/master@{#454054}
Committed:
https://chromium.googlesource.com/chromium/src/+/13edaa9f1b449a0de7fb6529c522...
==========

[commit-bot: I haz the power, 2017-03-01 22:01:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/13edaa9f1b449a0de7fb6529c522...