Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2726933002: [DevTools] Console should wait for the main target (Closed)

Created:
3 years, 9 months ago by eostroukhov
Modified:
3 years, 9 months ago
Reviewers:
einbinder, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Console should wait for the main target BUG=694761 Review-Url: https://codereview.chromium.org/2726933002 Cr-Commit-Position: refs/heads/master@{#454054} Committed: https://chromium.googlesource.com/chromium/src/+/13edaa9f1b449a0de7fb6529c5227751668a4ec9

Patch Set 1 #

Total comments: 2

Patch Set 2 : [DevTools] Console should wait for the main target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 4 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
eostroukhov
Please take a look.
3 years, 9 months ago (2017-03-01 19:17:12 UTC) #4
einbinder
https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode211 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:211: _initConsoleMessages() { Maybe this should take mainTarget as an ...
3 years, 9 months ago (2017-03-01 20:15:45 UTC) #5
eostroukhov
Please, take another look. https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2726933002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode211 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:211: _initConsoleMessages() { On 2017/03/01 20:15:45, ...
3 years, 9 months ago (2017-03-01 20:23:31 UTC) #8
dgozman
lgtm
3 years, 9 months ago (2017-03-01 20:28:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726933002/20001
3 years, 9 months ago (2017-03-01 20:31:46 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:01:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/13edaa9f1b449a0de7fb6529c522...

Powered by Google App Engine
This is Rietveld 408576698