Expose WebServiceWorkerNetworkProvider on DataSource

Expose WebServiceWorkerNetworkProvider on DataSource

While this exposes SW-related methods on DataSource, it also allows us to:

- remove SW-related methods from WebFrameClient
- remove cryptic entanglement between ServiceWorker and DataSource
  (DocumentLoader) that was done by ExtraData and UserData magic

BUG=538751
Review-Url: https://codereview.chromium.org/2733283004
Cr-Commit-Position: refs/heads/master@{#456081}
Committed: https://chromium.googlesource.com/chromium/src/+/bd180ddb1d14f49501f451a0117da5187deffb62

[kinuko, 2017-03-08 06:16:21]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 06:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-03-08 06:19:31]

Description was changed from

==========
Expose WebServiceWorkerNetworkProvider on DataSource

While this exposes SW-related methods on DataSource, it also allows us to:

- remove SW-related methods from WebFrameClient
- make the relationship between ServiceWorker and DataSource
  (DocumentLoader) a lot clearer

BUG=538751
==========

to

==========
Expose WebServiceWorkerNetworkProvider on DataSource

While this exposes SW-related methods on DataSource, it also allows us to:

- remove SW-related methods from WebFrameClient
- remove cryptic entanglement between ServiceWorker and DataSource
  (DocumentLoader) that was done by ExtraData and UserData magic

BUG=538751
==========

[commit-bot: I haz the power, 2017-03-08 06:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:30:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-03-08 07:13:22]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 07:13:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 07:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:24:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kinuko, 2017-03-08 07:38:22]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 07:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 08:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 08:28:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-03-08 10:22:30]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 10:22:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 10:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 10:59:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kinuko, 2017-03-08 16:04:05]

Patchset #4 (id:60001) has been deleted

[kinuko, 2017-03-08 16:04:12]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 16:04:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 17:20:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 17:20:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kinuko, 2017-03-09 14:19:16]

Patchset #3 (id:40001) has been deleted

[kinuko, 2017-03-09 14:19:24]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 14:19:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-03-09 16:11:04]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 16:11:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-03-09 16:23:02]

kinuko@chromium.org changed reviewers:
+ dcheng@chromium.org, falken@chromium.org, horo@chromium.org,
japhet@chromium.org

[kinuko, 2017-03-09 16:23:03]

What do you think about this one?

japhet@, dcheng@: DataSource, DocumentLoader, Frame related changes (and
overall)

horo@, falken@: SW related changes

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.h (right):

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:52:
blink::WebServiceWorkerNetworkProvider*);
This is a little awkward, maybe we can make ServiceWorkerNetworkProvider
directly inherit from WebServiceWorkerNetworkProvider (in a separate patch)

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:294:
m_serviceWorkerNetworkProvider;
This change exposes ServiceWorker to DocumentLoader, but we already leak SW
concept at many places in core/ and I think it's better to centralize SW-related
plumbing into this one

[commit-bot: I haz the power, 2017-03-09 18:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 18:48:55]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-03-09 19:52:07]

LGTM

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:76: #include
"public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h"
Are there rules about including public/platform/modules from outside of
Source/modules?

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp:338:
networkProvider->willSendRequest(request);
Can we move this (and the equivalent one in WebSharedWorkerImpl) to
FrameFetchContext now?

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/pub...
File
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h
(right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h:43:
// An instance of this class is owned by the associated DataSource, e.g.
e.g. -> i.e. ?

Are there plans to have non-DocumentLoader WebDataSources?

[kinuko, 2017-03-10 01:51:03]

Thanks!

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:76: #include
"public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h"
On 2017/03/09 19:52:07, Nate Chapin wrote:
> Are there rules about including public/platform/modules from outside of
> Source/modules?

Looks like we have some precedents (and they were just in public/platform back
then) so I suppose it's okay.

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp:338:
networkProvider->willSendRequest(request);
On 2017/03/09 19:52:07, Nate Chapin wrote:
> Can we move this (and the equivalent one in WebSharedWorkerImpl) to
> FrameFetchContext now?

Yeah I want to remove this too, but that requires a bit more changes in
RenderFrameImpl and FrameFetchContext.

Let me try it in a separate patch.

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/pub...
File
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h
(right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h:43:
// An instance of this class is owned by the associated DataSource, e.g.
On 2017/03/09 19:52:07, Nate Chapin wrote:
> e.g. -> i.e. ?
> 
> Are there plans to have non-DocumentLoader WebDataSources?

No, but we may start to associate this with non-document loading context for
worker cases (without going through DataSource).  I'll change 'DataSource' to a
generic noun like 'loading context'.

[falken, 2017-03-10 04:26:01]

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.h (right):

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:42: // with
WebServiceWorkerNetworkProvider to be owned by blink.
super nitty: Blink ("blink" for the namespace only)

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:51: static
ServiceWorkerNetworkProvider* GetInwardProviderForNavigation(
"Inward" seems like an uncommon term. Would
"FromWebServiceWorkerNetworkProvider()" be more standard naming?

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/rende...
content/renderer/render_frame_impl.cc:4325: // This must be done after we set
extra data.
Could you also write (briefly) why the order matters, to guard against comment
staleness in case the code later changes. It's not obvious to me.

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:195:
WebServiceWorkerNetworkProvider* getServiceWorkerNetworkProvider() {
It seems worth documenting that this can be null. (Do you know in which cases it
can be null? I guess it's before the document has finished loading?)

also (nit) Should this just be serviceWorkerNetworkProvider()? This class isn't
consistent about it though.

[horo, 2017-03-10 04:43:28]

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.cc:48: class
WebServiceWorkerNetworkProviderForNavigation
"ForNavigation" looks misleading. I think "ForFrame" is better.

This class is created when the navigation happens.
But it will be used for all requests from the frame.

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/share...
File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/share...
content/renderer/shared_worker/embedded_shared_worker_stub.cc:112: bool
is_secure_context_ = false;
nit:
const bool is_secure_context_;

[dcheng, 2017-03-10 04:48:38]

lgtm

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:827: auto
service_worker_network_provider =
auto* here and below as well

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:173: auto networkProvider
= frame->dataSource()->getServiceWorkerNetworkProvider();
Nit: auto* (this is checked automatically in Chrome code, but isn't yet enabled
in Blink)

[kinuko, 2017-03-10 05:52:17]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[kinuko, 2017-03-10 05:52:29]

Thanks, updated.

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.cc:48: class
WebServiceWorkerNetworkProviderForNavigation
On 2017/03/10 04:43:28, horo wrote:
> "ForNavigation" looks misleading. I think "ForFrame" is better.
> 
> This class is created when the navigation happens.
> But it will be used for all requests from the frame.

Done.  (Does it make sense to CreateForNavigation too?  It looks a little weird
to return XForFrame from XForNavigation)

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.h (right):

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:42: // with
WebServiceWorkerNetworkProvider to be owned by blink.
On 2017/03/10 04:26:00, falken wrote:
> super nitty: Blink ("blink" for the namespace only)

Done.

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:51: static
ServiceWorkerNetworkProvider* GetInwardProviderForNavigation(
On 2017/03/10 04:26:00, falken wrote:
> "Inward" seems like an uncommon term. Would
> "FromWebServiceWorkerNetworkProvider()" be more standard naming?

Sounds much better, done.

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/rende...
content/renderer/render_frame_impl.cc:4325: // This must be done after we set
extra data.
On 2017/03/10 04:26:00, falken wrote:
> Could you also write (briefly) why the order matters, to guard against comment
> staleness in case the code later changes. It's not obvious to me.

Revised to make it order-independent.

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/share...
File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/renderer/share...
content/renderer/shared_worker/embedded_shared_worker_stub.cc:112: bool
is_secure_context_ = false;
On 2017/03/10 04:43:28, horo wrote:
> nit:
> const bool is_secure_context_;

Done.

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:195:
WebServiceWorkerNetworkProvider* getServiceWorkerNetworkProvider() {
On 2017/03/10 04:26:00, falken wrote:
> It seems worth documenting that this can be null. (Do you know in which cases
it
> can be null? I guess it's before the document has finished loading?)

Done.  Also removed some null checks that seem unnecessary.
 
> also (nit) Should this just be serviceWorkerNetworkProvider()? This class
isn't
> consistent about it though.

I generally add get/set prefix for new code, once great rename happens it'd
become more natural.

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:827: auto
service_worker_network_provider =
On 2017/03/10 04:48:38, dcheng wrote:
> auto* here and below as well

Done.

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/2733283004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:173: auto networkProvider
= frame->dataSource()->getServiceWorkerNetworkProvider();
On 2017/03/10 04:48:38, dcheng wrote:
> Nit: auto* (this is checked automatically in Chrome code, but isn't yet
enabled
> in Blink)

Done.

[commit-bot: I haz the power, 2017-03-10 05:52:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 06:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 06:36:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[horo, 2017-03-10 07:35:33]

lgtm

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.cc (right):

https://codereview.chromium.org/2733283004/diff/120001/content/child/service_...
content/child/service_worker/service_worker_network_provider.cc:48: class
WebServiceWorkerNetworkProviderForNavigation
On 2017/03/10 05:52:28, kinuko wrote:
> On 2017/03/10 04:43:28, horo wrote:
> > "ForNavigation" looks misleading. I think "ForFrame" is better.
> > 
> > This class is created when the navigation happens.
> > But it will be used for all requests from the frame.
> 
> Done.  (Does it make sense to CreateForNavigation too?  It looks a little
weird
> to return XForFrame from XForNavigation)

I think the method name CreateForNavigation is OK.

[falken, 2017-03-10 08:29:09]

lgtm. Some bots are red, can't tell if it's due to this patch.

https://codereview.chromium.org/2733283004/diff/140001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.h (right):

https://codereview.chromium.org/2733283004/diff/140001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:49: // Returns
inward ServiceWorkerNetworkProvider. Valid only for
nit: "inward" is still odd, maybe we can just remove this sentence?

[kinuko, 2017-03-10 10:30:06]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 10:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-03-10 11:34:51]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 11:35:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-03-10 11:35:46]

Thanks!  Fixing tests, will land once they look good

https://codereview.chromium.org/2733283004/diff/140001/content/child/service_...
File content/child/service_worker/service_worker_network_provider.h (right):

https://codereview.chromium.org/2733283004/diff/140001/content/child/service_...
content/child/service_worker/service_worker_network_provider.h:49: // Returns
inward ServiceWorkerNetworkProvider. Valid only for
On 2017/03/10 08:29:08, falken wrote:
> nit: "inward" is still odd, maybe we can just remove this sentence?

Done.

https://codereview.chromium.org/2733283004/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/2733283004/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/FrameFetchContext.cpp:829:
DCHECK(service_worker_network_provider);
I restored the null checks here and below to fix crashes

https://codereview.chromium.org/2733283004/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/exported/WebURLRequest.cpp (right):

https://codereview.chromium.org/2733283004/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebURLRequest.cpp:367: if (extraData
!= getExtraData())
I added this line so that 'data = getExtraData()' and then 'setExtraData(data)'
still work (it was a bit unintuitive it was a destructive operation...)

[commit-bot: I haz the power, 2017-03-10 13:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 13:30:56]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-03-10 16:44:15]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-03-10 16:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
dcheng@chromium.org, falken@chromium.org, horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2733283004/#ps180001
(title: "consistency")

[commit-bot: I haz the power, 2017-03-10 16:44:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 16:51:04]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1489164255545490,
"parent_rev": "7aa2519f44df0777bb5e457ed01cc4788a931705", "commit_rev":
"bd180ddb1d14f49501f451a0117da5187deffb62"}

[commit-bot: I haz the power, 2017-03-10 16:51:46]

Description was changed from

==========
Expose WebServiceWorkerNetworkProvider on DataSource

While this exposes SW-related methods on DataSource, it also allows us to:

- remove SW-related methods from WebFrameClient
- remove cryptic entanglement between ServiceWorker and DataSource
  (DocumentLoader) that was done by ExtraData and UserData magic

BUG=538751
==========

to

==========
Expose WebServiceWorkerNetworkProvider on DataSource

While this exposes SW-related methods on DataSource, it also allows us to:

- remove SW-related methods from WebFrameClient
- remove cryptic entanglement between ServiceWorker and DataSource
  (DocumentLoader) that was done by ExtraData and UserData magic

BUG=538751

Review-Url: https://codereview.chromium.org/2733283004
Cr-Commit-Position: refs/heads/master@{#456081}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd180ddb1d14f49501f451a0117d...
==========

[commit-bot: I haz the power, 2017-03-10 16:51:48]

Committed patchset #8 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/bd180ddb1d14f49501f451a0117d...