Expose WebServiceWorkerNetworkProvider on DataSource

third_party/WebKit/Source/core/loader/DocumentLoader.h

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 46 matching lines @@
 namespace blink {
 
 class ApplicationCacheHost;
 class SubresourceFilter;
 class ResourceFetcher;
 class DocumentInit;
 class LocalFrame;
 class LocalFrameClient;
 class FrameLoader;
 class ResourceTimingInfo;
+class WebServiceWorkerNetworkProvider;
 struct ViewportDescriptionWrapper;
 
 class CORE_EXPORT DocumentLoader
     : public GarbageCollectedFinalized<DocumentLoader>,
       private RawResourceClient {
   USING_GARBAGE_COLLECTED_MIXIN(DocumentLoader);
 
  public:
   static DocumentLoader* create(LocalFrame* frame,
                                 const ResourceRequest& request,
@@ skipping 105 matching lines @@
   InitialScrollState& initialScrollState() { return m_initialScrollState; }
 
   void setWasBlockedAfterCSP() { m_wasBlockedAfterCSP = true; }
   bool wasBlockedAfterCSP() { return m_wasBlockedAfterCSP; }
 
   void dispatchLinkHeaderPreloads(ViewportDescriptionWrapper*,
                                   LinkLoader::MediaPreloadPolicy);
 
   Resource* startPreload(Resource::Type, FetchRequest&);
 
+  void setServiceWorkerNetworkProvider(
+      std::unique_ptr<WebServiceWorkerNetworkProvider>);
+  WebServiceWorkerNetworkProvider* getServiceWorkerNetworkProvider() {

[falken, 2017/03/10 04:26:00]

It seems worth documenting that this can be null. (Do you know in which cases it
can be null? I guess it's before the document has finished loading?)

also (nit) Should this just be serviceWorkerNetworkProvider()? This class isn't
consistent about it though.

[kinuko, 2017/03/10 05:52:29]

Done.  Also removed some null checks that seem unnecessary.
 
I generally add get/set prefix for new code, once great rename happens it'd
become more natural.

+    return m_serviceWorkerNetworkProvider.get();
+  }
+
   DECLARE_VIRTUAL_TRACE();
 
  protected:
   DocumentLoader(LocalFrame*,
                  const ResourceRequest&,
                  const SubstituteData&,
                  ClientRedirectPolicy);
 
   Vector<KURL> m_redirectChain;
 
@@ skipping 74 matching lines @@
   bool m_dataReceived;
 
   NavigationType m_navigationType;
 
   DocumentLoadTiming m_documentLoadTiming;
 
   double m_timeOfLastDataReceived;
 
   Member<ApplicationCacheHost> m_applicationCacheHost;
 
+  std::unique_ptr<WebServiceWorkerNetworkProvider>
+      m_serviceWorkerNetworkProvider;

[kinuko, 2017/03/09 16:23:03]

This change exposes ServiceWorker to DocumentLoader, but we already leak SW
concept at many places in core/ and I think it's better to centralize SW-related
plumbing into this one

+
   Member<ContentSecurityPolicy> m_contentSecurityPolicy;
   ClientHintsPreferences m_clientHintsPreferences;
   InitialScrollState m_initialScrollState;
 
   bool m_wasBlockedAfterCSP;
 
   enum State {
     NotStarted,
     Provisional,
     Committed,
     SentDidFinishLoad
   };
   State m_state;
 
   // Used to protect against reentrancy into dataReceived().
   bool m_inDataReceived;
   RefPtr<SharedBuffer> m_dataBuffer;
 };
 
 DECLARE_WEAK_IDENTIFIER_MAP(DocumentLoader);
 
 }  // namespace blink
 
 #endif  // DocumentLoader_h