Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2733253003:
platform/loader: move test file definition to platform/loader/BUILD.gn (Closed)
|
Created:
3 years, 9 months ago by Takashi Toyoshima Modified:
3 years, 9 months ago Reviewers:
kinuko CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionplatform/loader: move test file definition to platform/loader/BUILD.gn
platform/loader has a BUILD.gn, but it defines only production files,
and files for testing are still defined in platform/BUilD.gn.
This patch moves test file definitions for blink_platform_unittests
from platform/BUILD.gn to platform/loader/BUILD.gn.
BUG=699369
Review-Url: https://codereview.chromium.org/2733253003
Cr-Commit-Position: refs/heads/master@{#455696}
Committed: https://chromium.googlesource.com/chromium/src/+/b823112b71ffde298c16004758cf78953ecdd3cc
Patch Set 1 #Patch Set 2 : visibility fix for android #Patch Set 3 : rebase #
Dependent Patchsets: Messages
Total messages: 21 (18 generated)
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Description was changed from ========== platform/loader: move test file definition to platform/loader/BUILD.gn platform/loader has a BUILD.gn, but it defines only production files, and files for testing are still defined in platform/BUilD.gn. This patch moves test file definitions for blink_platform_unittests from platform/BUILD.gn to platform/loader/BUILD.gn. BUG=699369 ========== to ========== platform/loader: move test file definition to platform/loader/BUILD.gn platform/loader has a BUILD.gn, but it defines only production files, and files for testing are still defined in platform/BUilD.gn. This patch moves test file definitions for blink_platform_unittests from platform/BUILD.gn to platform/loader/BUILD.gn. BUG=699369 ==========
toyoshim@chromium.org changed reviewers: + kinuko@chromium.org
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by toyoshim@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org Link to the patchset: https://codereview.chromium.org/2733253003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489041185637280,
"parent_rev": "319373dd4fdc7b2ab5db402844765f3dd9613bda", "commit_rev":
"b823112b71ffde298c16004758cf78953ecdd3cc"}
Message was sent while issue was closed.
Description was changed from ========== platform/loader: move test file definition to platform/loader/BUILD.gn platform/loader has a BUILD.gn, but it defines only production files, and files for testing are still defined in platform/BUilD.gn. This patch moves test file definitions for blink_platform_unittests from platform/BUILD.gn to platform/loader/BUILD.gn. BUG=699369 ========== to ========== platform/loader: move test file definition to platform/loader/BUILD.gn platform/loader has a BUILD.gn, but it defines only production files, and files for testing are still defined in platform/BUilD.gn. This patch moves test file definitions for blink_platform_unittests from platform/BUILD.gn to platform/loader/BUILD.gn. BUG=699369 Review-Url: https://codereview.chromium.org/2733253003 Cr-Commit-Position: refs/heads/master@{#455696} Committed: https://chromium.googlesource.com/chromium/src/+/b823112b71ffde298c16004758cf... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b823112b71ffde298c16004758cf... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
