Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2732243005: platform/loader: move test support files definition to loader/BUILD.gn (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

platform/loader: move test support files definition to loader/BUILD.gn platform/loader has a BUILD.gn, but it does not contain files for platform:test_support that can be used in blink_platform_unittests and webkit_unit_tests. This patch moves platform/loader/ files for the test_support from platform/BUILD.gn to platform/loader/BUILD.gn. BUG=699369 Review-Url: https://codereview.chromium.org/2732243005 Cr-Commit-Position: refs/heads/master@{#455713} Committed: https://chromium.googlesource.com/chromium/src/+/52c5e8a493370d2e50e88c8c53e34818a08812f5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/BUILD.gn View 1 1 chunk +30 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (10 generated)
kinuko
lgtm
3 years, 9 months ago (2017-03-08 05:42:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732243005/20001
3 years, 9 months ago (2017-03-09 08:36:21 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 11:19:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/52c5e8a493370d2e50e88c8c53e3...

Powered by Google App Engine
This is Rietveld 408576698