Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2733243003: LogDog: Use "winio" instead of "npipe". (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Use "winio" instead of "npipe". This should fix a pretty bad flake in Windows stream server testing. This is also a good health move, since "winio" is an official Microsoft library! BUG=chromium:699182 TEST=dev - Ran this on a development Windows machine, seems to be reliably working. R=nodir@chromium.org Review-Url: https://codereview.chromium.org/2733243003 Committed: https://github.com/luci/luci-go/commit/0061578294f73ba706c26bc6cf16ba8602e67d82

Patch Set 1 #

Patch Set 2 : reenable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M logdog/client/butler/streamserver/namedPipe_windows.go View 2 chunks +4 lines, -3 lines 0 comments Download
M logdog/client/butler/streamserver/namedPipe_windows_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M logdog/client/butlerlib/streamclient/client_namedPipe_windows.go View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
dnj
3 years, 9 months ago (2017-03-07 18:26:41 UTC) #1
nodir
lgtm
3 years, 9 months ago (2017-03-07 18:59:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733243003/1
3 years, 9 months ago (2017-03-07 19:31:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/34c31324116d5310)
3 years, 9 months ago (2017-03-07 19:36:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733243003/20001
3 years, 9 months ago (2017-03-07 20:33:19 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:40:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/0061578294f73ba706c26bc6cf16ba8602e67d82

Powered by Google App Engine
This is Rietveld 408576698