Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: logdog/client/butler/streamserver/namedPipe_windows.go

Issue 2733243003: LogDog: Use "winio" instead of "npipe". (Closed)
Patch Set: reenable test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | logdog/client/butler/streamserver/namedPipe_windows_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/butler/streamserver/namedPipe_windows.go
diff --git a/logdog/client/butler/streamserver/namedPipe_windows.go b/logdog/client/butler/streamserver/namedPipe_windows.go
index 09749762620d2fc3dfcc839dc5b672721aeed3ed..fb3d0c025e3a58ce61336c01884ba4b58f12d69e 100644
--- a/logdog/client/butler/streamserver/namedPipe_windows.go
+++ b/logdog/client/butler/streamserver/namedPipe_windows.go
@@ -7,12 +7,13 @@ package streamserver
import (
"net"
+ "golang.org/x/net/context"
+
"github.com/luci/luci-go/common/errors"
log "github.com/luci/luci-go/common/logging"
"github.com/luci/luci-go/logdog/client/butlerlib/streamclient"
- "golang.org/x/net/context"
- npipe "gopkg.in/natefinch/npipe.v2"
+ "github.com/Microsoft/go-winio"
)
// maxWindowsNamedPipeLength is the maximum length of a Windows named pipe.
@@ -41,7 +42,7 @@ func NewNamedPipeServer(ctx context.Context, name string) (StreamServer, error)
"pipePath": pipePath,
}.Debugf(ctx, "Creating Windows server socket Listener.")
- l, err := npipe.Listen(pipePath)
+ l, err := winio.ListenPipe(pipePath, nil)
if err != nil {
return nil, "", errors.Annotate(err).Reason("failed to listen on named pipe").Err()
}
« no previous file with comments | « no previous file | logdog/client/butler/streamserver/namedPipe_windows_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698