Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2733233002: [tools/android] Replace FlagReplacer with flag_changer equivalent (Closed)

Created:
3 years, 9 months ago by perezju
Modified:
3 years, 9 months ago
Reviewers:
pasko, Benoit L
CC:
chromium-reviews, lizeb+watch-android-loading_chromium.org, gabadie+watch_chromium.org, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/android] Replace FlagReplacer with flag_changer equivalent flag_changer.CustomCommandLineFlags is now a drop-in replacement for device_setup.FlagReplacer. This also helps keeping the code to deal with command line files in one place, which can be tweaked as needed to work well on future Android and Chrome versions. BUG=698205 Review-Url: https://codereview.chromium.org/2733233002 Cr-Commit-Position: refs/heads/master@{#455433} Committed: https://chromium.googlesource.com/chromium/src/+/bdc24416fa0ca3fa946506f299d3d36d39cb36a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -28 lines) Patch
M tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/android/loading/controller.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/android/loading/device_setup.py View 2 chunks +0 lines, -24 lines 0 comments Download
M tools/android/loading/wpr_helper.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/resource_prefetch_predictor/prefetch_benchmark.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
perezju
3 years, 9 months ago (2017-03-07 16:38:46 UTC) #2
perezju
Do let me know if there are any tests/commands to run to make sure this ...
3 years, 9 months ago (2017-03-08 10:54:01 UTC) #10
pasko
lgtm On 2017/03/08 10:54:01, perezju wrote: > Do let me know if there are any ...
3 years, 9 months ago (2017-03-08 11:33:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733233002/1
3 years, 9 months ago (2017-03-08 11:41:14 UTC) #13
perezju
On 2017/03/08 11:33:26, pasko wrote: > lgtm > > On 2017/03/08 10:54:01, perezju wrote: > ...
3 years, 9 months ago (2017-03-08 11:41:31 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 11:45:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdc24416fa0ca3fa946506f299d3...

Powered by Google App Engine
This is Rietveld 408576698