[tools/android] Replace FlagReplacer with flag_changer equivalent

[tools/android] Replace FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205
Review-Url: https://codereview.chromium.org/2733233002
Cr-Commit-Position: refs/heads/master@{#455433}
Committed: https://chromium.googlesource.com/chromium/src/+/bdc24416fa0ca3fa946506f299d3d36d39cb36a1

[perezju, 2017-03-07 16:38:45]

perezju@chromium.org changed reviewers:
+ lizeb@google.com, pasko@chromium.org

[perezju, 2017-03-07 16:38:55]

Description was changed from

==========
[tools/android] Replacer FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205
==========

to

==========
[tools/android] Replacer FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205
==========

[perezju, 2017-03-07 16:39:03]

Description was changed from

==========
[tools/android] Replacer FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205
==========

to

==========
[tools/android] Replace FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205
==========

[perezju, 2017-03-07 16:39:40]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 16:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 16:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:58:56]

Dry run: This issue passed the CQ dry run.

[perezju, 2017-03-08 10:54:01]

perezju@chromium.org changed reviewers:
+ lizeb@chromium.org
- lizeb@google.com

[perezju, 2017-03-08 10:54:01]

Do let me know if there are any tests/commands to run to make sure this doesn't
break anything.

[pasko, 2017-03-08 11:33:26]

lgtm

On 2017/03/08 10:54:01, perezju wrote:
> Do let me know if there are any tests/commands to run to make sure this
doesn't
> break anything.

If something breaks, we will discover it pretty soon, as several folks are using
this code right now.

lizeb: can we put a small howto in customtabs_benchmark.py for building the
driver app and such? A pointer to README.md would also be nice.

[perezju, 2017-03-08 11:40:57]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-03-08 11:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[perezju, 2017-03-08 11:41:31]

On 2017/03/08 11:33:26, pasko wrote:
> lgtm
> 
> On 2017/03/08 10:54:01, perezju wrote:
> > Do let me know if there are any tests/commands to run to make sure this
> doesn't
> > break anything.
> 
> If something breaks, we will discover it pretty soon, as several folks are
using
> this code right now.

sgtm

You'll know where to find me. :)

[commit-bot: I haz the power, 2017-03-08 11:45:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488973257335370, "parent_rev":
"90317a66a2ae85e810decc96c09f365e51a1fa7f", "commit_rev":
"bdc24416fa0ca3fa946506f299d3d36d39cb36a1"}

[commit-bot: I haz the power, 2017-03-08 11:45:53]

Description was changed from

==========
[tools/android] Replace FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205
==========

to

==========
[tools/android] Replace FlagReplacer with flag_changer equivalent

flag_changer.CustomCommandLineFlags is now a drop-in replacement for
device_setup.FlagReplacer. This also helps keeping the code to deal
with command line files in one place, which can be tweaked as needed
to work well on future Android and Chrome versions.

BUG=698205

Review-Url: https://codereview.chromium.org/2733233002
Cr-Commit-Position: refs/heads/master@{#455433}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdc24416fa0ca3fa946506f299d3...
==========

[commit-bot: I haz the power, 2017-03-08 11:45:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdc24416fa0ca3fa946506f299d3...