tools/android/loading/wpr_helper.py - Issue 2733233002: [tools/android] Replace FlagReplacer with flag_changer equivalent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/wpr_helper.py

Issue 2733233002: [tools/android] Replace FlagReplacer with flag_changer equivalent (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/loading/wpr_helper.py

diff --git a/tools/android/loading/wpr_helper.py b/tools/android/loading/wpr_helper.py

index ab655a596babe8cdc0e50f45ec8ef31655616cf7..b509d117b433714b7123aac2d4ef371ae5dc2dfe 100755

--- a/tools/android/loading/wpr_helper.py

+++ b/tools/android/loading/wpr_helper.py

@@ -17,6 +17,7 @@ _SRC_PATH = os.path.abspath(os.path.join(

sys.path.append(os.path.join(_SRC_PATH, 'third_party', 'catapult', 'devil'))

from devil.android import device_utils

+from devil.android import flag_changer

from devil.android.constants import chrome

from devil.android.perf import cache_control

from devil.android.sdk import intent

@@ -42,7 +43,7 @@ def RunChrome(device, cold, chrome_args, package_info):

cmdline_file = package_info.cmdline_file

package = package_info.package

- with device_setup.FlagReplacer(device, cmdline_file, chrome_args):

+ with flag_changer.CustomCommandLineFlags(device, cmdline_file, chrome_args):

device.ForceStop(package)

if cold: