FunctionEntryHook: require no-snapshot build

FunctionEntryHook: require no-snapshot build

When a FunctionEntryHook parameter was passed to isolate creation,
we ignored any existing snapshots anyway. Since the ability to
bootstrap from scratch will be removed from snapshot builds, the
FunctionEntryHook feature must depend on a no-snapshot build.

BUG=v8:6055
Review-Url: https://codereview.chromium.org/2733203002
Cr-Commit-Position: refs/heads/master@{#43779}
Committed: https://chromium.googlesource.com/v8/v8/+/d0e604bf261470b1404e2ddf6da29206dad72026

[Jakob Kummerow, 2017-03-07 10:28:03]

jkummerow@chromium.org changed reviewers:
+ jochen@chromium.org

[Jakob Kummerow, 2017-03-07 10:28:04]

PTAL.

PSA sent to v8-dev and v8-users.

[jochen (gone - plz use gerrit), 2017-03-07 10:30:35]

hum, that'll break chrome as is...
https://cs.chromium.org/chromium/src/gin/isolate_holder.cc?rcl=fd6ebdefe37285...

[Jakob Kummerow, 2017-03-07 10:36:14]

On 2017/03/07 10:30:35, jochen wrote:
> hum, that'll break chrome as is...
>
https://cs.chromium.org/chromium/src/gin/isolate_holder.cc?rcl=fd6ebdefe37285...

No, it shouldn't. Only instrumented Syzygy profiler builds actually pass in an
entry_hook, and according to the Syzygy team, the profiler is pretty much unused
these days. They were fine with introducing a dependency on nosnapshot builds.

[jochen (gone - plz use gerrit), 2017-03-07 10:37:00]

lgtm with comment

https://codereview.chromium.org/2733203002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2733203002/diff/20001/src/api.cc#newcode8159
src/api.cc:8159: CHECK(false);
can you make this an ApiCheck so it has some useful error message?

please also add a comment to the entry_hook declaration in v8.h

[Jakob Kummerow, 2017-03-07 10:47:14]

Thanks, comments addressed.

https://codereview.chromium.org/2733203002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2733203002/diff/20001/src/api.cc#newcode8159
src/api.cc:8159: CHECK(false);
On 2017/03/07 10:37:00, jochen wrote:
> can you make this an ApiCheck so it has some useful error message?

Done.

> please also add a comment to the entry_hook declaration in v8.h

Done.

[jochen (gone - plz use gerrit), 2017-03-07 11:42:44]

lgtm

https://codereview.chromium.org/2733203002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2733203002/diff/40001/include/v8.h#newcode6362
include/v8.h:6362: * builds it must be NULL.
nit nullptr

[Jakob Kummerow, 2017-03-07 12:43:42]

https://codereview.chromium.org/2733203002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2733203002/diff/40001/include/v8.h#newcode6362
include/v8.h:6362: * builds it must be NULL.
On 2017/03/07 11:42:44, jochen wrote:
> nit nullptr

Done.

[Jakob Kummerow, 2017-03-14 12:05:02]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-03-14 12:05:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2733203002/#ps60001
(title: "fix nit")

[commit-bot: I haz the power, 2017-03-14 12:05:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 12:31:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489493102707600,
"parent_rev": "822aef290fb8a99c9620a5417a61c078541c3dd7", "commit_rev":
"d0e604bf261470b1404e2ddf6da29206dad72026"}

[commit-bot: I haz the power, 2017-03-14 12:31:11]

Description was changed from

==========
FunctionEntryHook: require no-snapshot build

When a FunctionEntryHook parameter was passed to isolate creation,
we ignored any existing snapshots anyway. Since the ability to
bootstrap from scratch will be removed from snapshot builds, the
FunctionEntryHook feature must depend on a no-snapshot build.

BUG=v8:6055
==========

to

==========
FunctionEntryHook: require no-snapshot build

When a FunctionEntryHook parameter was passed to isolate creation,
we ignored any existing snapshots anyway. Since the ability to
bootstrap from scratch will be removed from snapshot builds, the
FunctionEntryHook feature must depend on a no-snapshot build.

BUG=v8:6055

Review-Url: https://codereview.chromium.org/2733203002
Cr-Commit-Position: refs/heads/master@{#43779}
Committed:
https://chromium.googlesource.com/v8/v8/+/d0e604bf261470b1404e2ddf6da29206dad...
==========

[commit-bot: I haz the power, 2017-03-14 12:31:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/d0e604bf261470b1404e2ddf6da29206dad...