Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/api.cc

Issue 2733203002: FunctionEntryHook: require no-snapshot build (Closed)
Patch Set: fix nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | test/cctest/cctest.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 866a0bc22441e84f5339397ba42f9ce2c190ea44..362ed440f605b5e129cfcc1237eabbe029be49d7 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -8154,6 +8154,12 @@ Isolate* Isolate::New(const Isolate::CreateParams& params) {
isolate->set_snapshot_blob(i::Snapshot::DefaultSnapshotBlob());
}
if (params.entry_hook) {
+#ifdef V8_USE_SNAPSHOT
+ // Setting a FunctionEntryHook is only supported in no-snapshot builds.
+ Utils::ApiCheck(
+ false, "v8::Isolate::New",
+ "Setting a FunctionEntryHook is only supported in no-snapshot builds.");
+#endif
isolate->set_function_entry_hook(params.entry_hook);
}
auto code_event_handler = params.code_event_handler;
« no previous file with comments | « include/v8.h ('k') | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698