Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2733153003: Revert of [remoting android] Generate trimmed-down credits.html. (Closed)

Created:
3 years, 9 months ago by amineer
Modified:
3 years, 9 months ago
Reviewers:
Lambros, Jamie, nicholss
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [remoting android] Generate trimmed-down credits.html. (patchset #2 id:20001 of https://codereview.chromium.org/2728913002/ ) Reason for revert: Breaks Android official builds BUG=699088 Original issue's description: > [remoting android] Generate trimmed-down credits.html. > > This copies resources to a central location, so that the Android build > is independent of anything under remoting/webapp. > > This provides GN options to tools/licenses.py to only list third-party > projects that are included in the app (currently the "remoting_apk" > target, but followup work will enable us to specify the actual target > for Official builds). > > Also stripped out CSS rules that were only meaningful for the webapp. > > > BUG=697128, 178215 > > Review-Url: https://codereview.chromium.org/2728913002 > Cr-Commit-Position: refs/heads/master@{#454936} > Committed: https://chromium.googlesource.com/chromium/src/+/aeec4d330e053262b28e1559f2c052206aad3aad TBR=jamiewalch@chromium.org,nicholss@chromium.org,lambroslambrou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697128, 178215 Review-Url: https://codereview.chromium.org/2733153003 Cr-Commit-Position: refs/heads/master@{#455118} Committed: https://chromium.googlesource.com/chromium/src/+/5910889b1aa6e3775eb7cb9539dc096e16050aa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -158 lines) Patch
M remoting/android/BUILD.gn View 1 chunk +5 lines, -33 lines 0 comments Download
D remoting/credits/credits.tmpl View 1 chunk +0 lines, -18 lines 0 comments Download
D remoting/credits/credits_css.css View 1 chunk +0 lines, -75 lines 0 comments Download
D remoting/credits/credits_entry.tmpl View 1 chunk +0 lines, -12 lines 0 comments Download
D remoting/credits/credits_js.js View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
amineer
Created Revert of [remoting android] Generate trimmed-down credits.html.
3 years, 9 months ago (2017-03-07 17:29:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733153003/1
3 years, 9 months ago (2017-03-07 17:30:24 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:36:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5910889b1aa6e3775eb7cb9539dc...

Powered by Google App Engine
This is Rietveld 408576698