[remoting android] Generate trimmed-down credits.html.

[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/licenses.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128, 178215, 699088
Review-Url: https://codereview.chromium.org/2728913002
Cr-Commit-Position: refs/heads/master@{#455578}
Committed: https://chromium.googlesource.com/chromium/src/+/7703f4bb5c3bed162c3e7c753e731f8f2816aa39

[Lambros, 2017-03-02 03:07:54]

lambroslambrou@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Lambros, 2017-03-02 03:07:55]

I used remoting/credits/ but feel free to suggest another location, maybe
remoting/base or remoting/resources ?

[Jamie, 2017-03-02 18:37:01]

jamiewalch@chromium.org changed reviewers:
+ nicholss@chromium.org

[Jamie, 2017-03-02 18:37:02]

LGTM, but I don't speak fluent GN. Scott, would you mind signing off on that?

https://codereview.chromium.org/2728913002/diff/1/remoting/android/BUILD.gn
File remoting/android/BUILD.gn (right):

https://codereview.chromium.org/2728913002/diff/1/remoting/android/BUILD.gn#n...
remoting/android/BUILD.gn:103: "//remoting/credits/main.css",
Is it worth splitting the CSS into two files? IIRC, it was only done that way
previously because the main.css rules apply to the whole app.

[Lambros, 2017-03-02 20:33:00]

https://codereview.chromium.org/2728913002/diff/1/remoting/android/BUILD.gn
File remoting/android/BUILD.gn (right):

https://codereview.chromium.org/2728913002/diff/1/remoting/android/BUILD.gn#n...
remoting/android/BUILD.gn:67: action("credits") {
If it helps reviewing, this section is based off of //remoting/webapp:credits
https://cs.chromium.org/chromium/src/remoting/webapp/BUILD.gn?q=credits&l=11

[Lambros, 2017-03-03 01:53:16]

https://codereview.chromium.org/2728913002/diff/1/remoting/android/BUILD.gn
File remoting/android/BUILD.gn (right):

https://codereview.chromium.org/2728913002/diff/1/remoting/android/BUILD.gn#n...
remoting/android/BUILD.gn:103: "//remoting/credits/main.css",
On 2017/03/02 18:37:01, Jamie wrote:
> Is it worth splitting the CSS into two files? IIRC, it was only done that way
> previously because the main.css rules apply to the whole app.

Removed main.css and moved some styles into credits_css.css

[nicholss, 2017-03-06 18:15:58]

lgtm

[Lambros, 2017-03-06 19:19:15]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2017-03-06 19:19:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2728913002/#ps20001
(title: "Removed main.css")

[commit-bot: I haz the power, 2017-03-06 19:20:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:22:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488827955596640,
"parent_rev": "58f544ff4a6a83322f90229ab7736d9d1d77d6bf", "commit_rev":
"aeec4d330e053262b28e1559f2c052206aad3aad"}

[commit-bot: I haz the power, 2017-03-06 20:22:50]

Description was changed from

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.


BUG=697128,178215
==========

to

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.


BUG=697128,178215

Review-Url: https://codereview.chromium.org/2728913002
Cr-Commit-Position: refs/heads/master@{#454936}
Committed:
https://chromium.googlesource.com/chromium/src/+/aeec4d330e053262b28e1559f2c0...
==========

[commit-bot: I haz the power, 2017-03-06 20:22:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aeec4d330e053262b28e1559f2c0...

[amineer, 2017-03-07 17:29:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2733153003/ by amineer@chromium.org.

The reason for reverting is: Breaks Android official builds

BUG=699088.

[Lambros, 2017-03-08 20:00:43]

Description was changed from

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.


BUG=697128,178215

Review-Url: https://codereview.chromium.org/2728913002
Cr-Commit-Position: refs/heads/master@{#454936}
Committed:
https://chromium.googlesource.com/chromium/src/+/aeec4d330e053262b28e1559f2c0...
==========

to

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/license.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128,178215
==========

[Lambros, 2017-03-08 20:00:43]

lambroslambrou@chromium.org changed reviewers:
+ dpranke@chromium.org
- nicholss@chromium.org

[Lambros, 2017-03-08 20:00:43]

lambroslambrou@chromium.org changed required reviewers:
+ dpranke@chromium.org

[Lambros, 2017-03-08 20:03:34]

Description was changed from

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/license.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128,178215
==========

to

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/licenses.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128,178215,699088
==========

[Lambros, 2017-03-08 20:09:05]

Dirk: please review tools/licenses.py
Jamie: FYI, no remoting/ changes.

[Dirk Pranke, 2017-03-08 21:10:43]

lgtm

[Lambros, 2017-03-08 21:18:22]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2017-03-08 21:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org, nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2728913002/#ps40001
(title: "Use GN binary from //buildtools.")

[commit-bot: I haz the power, 2017-03-08 21:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:11:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lambros, 2017-03-08 22:27:07]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:06:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489012027973770,
"parent_rev": "04cfe4a2d4c4d6feac254edee952ce74ce6600a1", "commit_rev":
"7703f4bb5c3bed162c3e7c753e731f8f2816aa39"}

[commit-bot: I haz the power, 2017-03-08 23:06:47]

Description was changed from

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/licenses.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128,178215,699088
==========

to

==========
[remoting android] Generate trimmed-down credits.html.

This copies resources to a central location, so that the Android build
is independent of anything under remoting/webapp.

This provides GN options to tools/licenses.py to only list third-party
projects that are included in the app (currently the "remoting_apk"
target, but followup work will enable us to specify the actual target
for Official builds).

Also stripped out CSS rules that were only meaningful for the webapp.

This also updates tools/licenses.py to use GN from //buildtools to
address a previous breakage on official Android builders.

BUG=697128,178215,699088

Review-Url: https://codereview.chromium.org/2728913002
Cr-Commit-Position: refs/heads/master@{#455578}
Committed:
https://chromium.googlesource.com/chromium/src/+/7703f4bb5c3bed162c3e7c753e73...
==========

[commit-bot: I haz the power, 2017-03-08 23:06:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7703f4bb5c3bed162c3e7c753e73...