Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2732873003: Revert of Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_… (Closed)

Created:
3 years, 9 months ago by sclittle
Modified:
3 years, 9 months ago
Reviewers:
jam, Sami, nasko
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_… (patchset #1 id:20001 of https://codereview.chromium.org/2727913006/ ) Reason for revert: Broke Linux debug builder: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29 https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/61426 Original issue's description: > Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. > > Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. > > Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. > > BUG=504347 > > Review-Url: https://codereview.chromium.org/2727913006 > Cr-Commit-Position: refs/heads/master@{#454922} > Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1 TBR=skyostil@chromium.org,nasko@chromium.org,jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504347 Review-Url: https://codereview.chromium.org/2732873003 Cr-Commit-Position: refs/heads/master@{#454996} Committed: https://chromium.googlesource.com/chromium/src/+/32db862712e8aff6d5015b9c7156a9f551c5428e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M headless/public/util/protocol_handler_request_id_browsertest.cc View 2 chunks +1 line, -16 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
sclittle
3 years, 9 months ago (2017-03-06 23:27:26 UTC) #2
Created Revert of Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest
with PlzNavigate to green up headless_…

Powered by Google App Engine
This is Rietveld 408576698