Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2727913006: Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_… (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
Sami, nasko, jam1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2727913006 Cr-Original-Commit-Position: refs/heads/master@{#454922} Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1 Review-Url: https://codereview.chromium.org/2727913006 . Cr-Commit-Position: refs/heads/master@{#455039} Committed: https://chromium.googlesource.com/chromium/src/+/04eb2294fb3baa85315da61ef38a3ce225794f0a

Patch Set 1 #

Total comments: 1

Patch Set 2 : reupload after revert #

Patch Set 3 : attempted fix since can't repro locally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M headless/lib/headless_devtools_client_browsertest.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M headless/public/util/protocol_handler_request_id_browsertest.cc View 2 chunks +16 lines, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 39 (30 generated)
jam
3 years, 9 months ago (2017-03-03 19:51:27 UTC) #4
jam
redirecting to Nasko since Sami is OOO
3 years, 9 months ago (2017-03-06 15:33:05 UTC) #14
nasko
LGTM https://codereview.chromium.org/2727913006/diff/20001/headless/public/util/protocol_handler_request_id_browsertest.cc File headless/public/util/protocol_handler_request_id_browsertest.cc (right): https://codereview.chromium.org/2727913006/diff/20001/headless/public/util/protocol_handler_request_id_browsertest.cc#newcode189 headless/public/util/protocol_handler_request_id_browsertest.cc:189: run_loop.Run(); The explanation of why this is needed ...
3 years, 9 months ago (2017-03-06 18:38:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727913006/20001
3 years, 9 months ago (2017-03-06 18:53:55 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1
3 years, 9 months ago (2017-03-06 19:45:50 UTC) #23
sclittle
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/2732873003/ by sclittle@chromium.org. ...
3 years, 9 months ago (2017-03-06 23:27:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727913006/60001
3 years, 9 months ago (2017-03-07 01:41:59 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395379)
3 years, 9 months ago (2017-03-07 03:55:55 UTC) #37
jam
3 years, 9 months ago (2017-03-07 05:39:17 UTC) #39
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
04eb2294fb3baa85315da61ef38a3ce225794f0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698