|
|
DescriptionDisable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again.
Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions.
Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall.
BUG=504347
R=nasko@chromium.org
Review-Url: https://codereview.chromium.org/2727913006
Cr-Original-Commit-Position: refs/heads/master@{#454922}
Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1
Review-Url: https://codereview.chromium.org/2727913006 .
Cr-Commit-Position: refs/heads/master@{#455039}
Committed: https://chromium.googlesource.com/chromium/src/+/04eb2294fb3baa85315da61ef38a3ce225794f0a
Patch Set 1 #
Total comments: 1
Patch Set 2 : reupload after revert #Patch Set 3 : attempted fix since can't repro locally #
Messages
Total messages: 39 (30 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jam@chromium.org changed reviewers: + skyostil@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. BUG=504347 ========== to ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 ==========
jam@chromium.org changed reviewers: + nasko@chromium.org
redirecting to Nasko since Sami is OOO
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM https://codereview.chromium.org/2727913006/diff/20001/headless/public/util/pr... File headless/public/util/protocol_handler_request_id_browsertest.cc (right): https://codereview.chromium.org/2727913006/diff/20001/headless/public/util/pr... headless/public/util/protocol_handler_request_id_browsertest.cc:189: run_loop.Run(); The explanation of why this is needed is at https://codereview.chromium.org/2720543002/#msg25.
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488826425508570, "parent_rev": "11a3425fff09d249101f8fb0dcd9c00ddb80283b", "commit_rev": "ebeb36a0ed4b69c72ce8f2c803bf4233d1cea9f1"}
Message was sent while issue was closed.
Description was changed from ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 ========== to ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 Review-Url: https://codereview.chromium.org/2727913006 Cr-Commit-Position: refs/heads/master@{#454922} Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/2732873003/ by sclittle@chromium.org. The reason for reverting is: Broke Linux debug builder: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%... https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%....
Message was sent while issue was closed.
Description was changed from ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 Review-Url: https://codereview.chromium.org/2727913006 Cr-Commit-Position: refs/heads/master@{#454922} Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf... ========== to ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 Review-Url: https://codereview.chromium.org/2727913006 Cr-Commit-Position: refs/heads/master@{#454922} Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf... ==========
The CQ bit was checked by jam@chromium.org to run a CQ dry run
The CQ bit was unchecked by jam@google.com
The CQ bit was checked by jam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jam@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2727913006/#ps60001 (title: "attempted fix since can't repro locally")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 Review-Url: https://codereview.chromium.org/2727913006 Cr-Commit-Position: refs/heads/master@{#454922} Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf... ========== to ========== Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_browsertests again. Also run headless_browsertests with PlzNavigate on the CQ to avoid future regressions. Lastly, run headless_browsertests on debug Linux bot. This is needed otherwise a DCHECK will break the CQ but won't show up on the main waterfall. BUG=504347 R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2727913006 Cr-Original-Commit-Position: refs/heads/master@{#454922} Committed: https://chromium.googlesource.com/chromium/src/+/ebeb36a0ed4b69c72ce8f2c803bf... Review-Url: https://codereview.chromium.org/2727913006 . Cr-Commit-Position: refs/heads/master@{#455039} Committed: https://chromium.googlesource.com/chromium/src/+/04eb2294fb3baa85315da61ef38a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 04eb2294fb3baa85315da61ef38a3ce225794f0a (presubmit successful). |