Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2732713003: Delete old client info migration behavior. (Closed)

Created:
3 years, 9 months ago by Steven Holte
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete old client info migration behavior. BUG= Review-Url: https://codereview.chromium.org/2732713003 Cr-Commit-Position: refs/heads/master@{#457319} Committed: https://chromium.googlesource.com/chromium/src/+/17f4b3fb7897a423a8fb90068b37a7c92f6f624f

Patch Set 1 #

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -113 lines) Patch
M components/metrics/metrics_state_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/metrics/metrics_state_manager.cc View 2 chunks +6 lines, -36 lines 0 comments Download
M components/metrics/metrics_state_manager_unittest.cc View 1 7 chunks +83 lines, -74 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Steven Holte
I found these references to old milestones in the code. Do you know if there ...
3 years, 9 months ago (2017-03-03 21:03:59 UTC) #2
Alexei Svitkine (slow)
lgtm, thanks for the clean up! If there's no bug id in the comments, I ...
3 years, 9 months ago (2017-03-03 21:15:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732713003/1
3 years, 9 months ago (2017-03-03 21:18:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/293197)
3 years, 9 months ago (2017-03-03 21:26:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732713003/20001
3 years, 9 months ago (2017-03-16 00:26:36 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:25:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17f4b3fb7897a423a8fb90068b37...

Powered by Google App Engine
This is Rietveld 408576698