Delete old client info migration behavior.

components/metrics/metrics_state_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/metrics_state_manager.h"
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/guid.h"
@@ skipping 74 matching lines @@
 void MetricsStateManager::ForceClientIdCreation() {
   {
     std::string client_id_from_prefs =
         local_state_->GetString(prefs::kMetricsClientID);
     // If client id in prefs matches the cached copy, return early.
     if (!client_id_from_prefs.empty() && client_id_from_prefs == client_id_)
       return;
     client_id_.swap(client_id_from_prefs);
   }
 
-  if (!client_id_.empty()) {
-    // It is technically sufficient to only save a backup of the client id when
-    // it is initially generated below, but since the backup was only introduced
-    // in M38, seed it explicitly from here for some time.
-    BackUpCurrentClientInfo();
+  if (!client_id_.empty())
     return;
-  }
 
-  const std::unique_ptr<ClientInfo> client_info_backup =
-      LoadClientInfoAndMaybeMigrate();
+  const std::unique_ptr<ClientInfo> client_info_backup = LoadClientInfo();
   if (client_info_backup) {
     client_id_ = client_info_backup->client_id;
 
     const base::Time now = base::Time::Now();
 
     // Save the recovered client id and also try to reinstantiate the backup
     // values for the dates corresponding with that client id in order to avoid
     // weird scenarios where we could report an old client id with a recent
     // install date.
     local_state_->SetString(prefs::kMetricsClientID, client_id_);
@@ skipping 111 matching lines @@
 
 void MetricsStateManager::BackUpCurrentClientInfo() {
   ClientInfo client_info;
   client_info.client_id = client_id_;
   client_info.installation_date = local_state_->GetInt64(prefs::kInstallDate);
   client_info.reporting_enabled_date =
       local_state_->GetInt64(prefs::kMetricsReportingEnabledTimestamp);
   store_client_info_.Run(client_info);
 }
 
-std::unique_ptr<ClientInfo>
-MetricsStateManager::LoadClientInfoAndMaybeMigrate() {
+std::unique_ptr<ClientInfo> MetricsStateManager::LoadClientInfo() {
   std::unique_ptr<ClientInfo> client_info = load_client_info_.Run();
 
-  // Prior to 2014-07, the client ID was stripped of its dashes before being
-  // saved. Migrate back to a proper GUID if this is the case. This migration
-  // code can be removed in M41+.
-  const size_t kGUIDLengthWithoutDashes = 32U;
-  if (client_info &&
-      client_info->client_id.length() == kGUIDLengthWithoutDashes) {
-    DCHECK(client_info->client_id.find('-') == std::string::npos);
-
-    std::string client_id_with_dashes;
-    client_id_with_dashes.reserve(kGUIDLengthWithoutDashes + 4U);
-    std::string::const_iterator client_id_it = client_info->client_id.begin();
-    for (size_t i = 0; i < kGUIDLengthWithoutDashes + 4U; ++i) {
-      if (i == 8U || i == 13U || i == 18U || i == 23U) {
-        client_id_with_dashes.push_back('-');
-      } else {
-        client_id_with_dashes.push_back(*client_id_it);
-        ++client_id_it;
-      }
-    }
-    DCHECK(client_id_it == client_info->client_id.end());
-    client_info->client_id.assign(client_id_with_dashes);
-  }
-
-  // The GUID retrieved (and possibly fixed above) should be valid unless
-  // retrieval failed. If not, return nullptr. This will result in a new GUID
-  // being generated by the calling function ForceClientIdCreation().
+  // The GUID retrieved should be valid unless retrieval failed.
+  // If not, return nullptr. This will result in a new GUID being generated by
+  // the calling function ForceClientIdCreation().
   if (client_info && !base::IsValidGUID(client_info->client_id))
     return nullptr;
 
   return client_info;
 }
 
 int MetricsStateManager::GetLowEntropySource() {
   UpdateLowEntropySource();
   return low_entropy_source_;
 }
@@ skipping 48 matching lines @@
 
   local_state_->ClearPref(prefs::kMetricsClientID);
   local_state_->ClearPref(prefs::kMetricsLowEntropySource);
   local_state_->ClearPref(prefs::kMetricsResetIds);
 
   // Also clear the backed up client info.
   store_client_info_.Run(ClientInfo());
 }
 
 }  // namespace metrics