Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2732483002: Change NGLayoutOpportunityIterator constructor to work with const CS. (Closed)

Created:
3 years, 9 months ago by Gleb Lanbin
Modified:
3 years, 9 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change NGLayoutOpportunityIterator constructor to work with const CS. List of changes: 1) Resolve "const NGConstraintSpace" TODO in NGFloatingObject 2) Change NGLayoutOpportunityIterator to work with a const CS. BUG=635619 Review-Url: https://codereview.chromium.org/2732483002 Cr-Commit-Position: refs/heads/master@{#454392} Committed: https://chromium.googlesource.com/chromium/src/+/9f81209c0afcb72f576f4794c28c11520b35d7bb

Patch Set 1 #

Patch Set 2 : git rebase-update #

Patch Set 3 : git rebase-update2 #

Patch Set 4 : git rebase-update3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -37 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 11 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_floating_object.h View 1 2 3 2 chunks +11 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
Gleb Lanbin
3 years, 9 months ago (2017-03-02 18:19:50 UTC) #3
ikilpatrick
lgtm
3 years, 9 months ago (2017-03-02 18:21:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732483002/20001
3 years, 9 months ago (2017-03-02 18:52:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732483002/60001
3 years, 9 months ago (2017-03-02 21:53:06 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:01:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9f81209c0afcb72f576f4794c28c...

Powered by Google App Engine
This is Rietveld 408576698