Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

Issue 2732483002: Change NGLayoutOpportunityIterator constructor to work with const CS. (Closed)
Patch Set: git rebase-update3 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_layout_opportunity_iterator.h" 5 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
6 6
7 #include "core/layout/ng/ng_units.h" 7 #include "core/layout/ng/ng_units.h"
8 #include "wtf/NonCopyingSort.h" 8 #include "wtf/NonCopyingSort.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 225
226 NGExclusion leader_exclusion; 226 NGExclusion leader_exclusion;
227 leader_exclusion.rect.offset = origin_point; 227 leader_exclusion.rect.offset = origin_point;
228 leader_exclusion.rect.size = {inline_size, block_size}; 228 leader_exclusion.rect.size = {inline_size, block_size};
229 return leader_exclusion; 229 return leader_exclusion;
230 } 230 }
231 231
232 } // namespace 232 } // namespace
233 233
234 NGLayoutOpportunityIterator::NGLayoutOpportunityIterator( 234 NGLayoutOpportunityIterator::NGLayoutOpportunityIterator(
235 NGConstraintSpace* space, 235 const NGConstraintSpace* space,
236 const WTF::Optional<NGLogicalOffset>& opt_origin_point, 236 const WTF::Optional<NGLogicalOffset>& opt_origin_point,
237 const WTF::Optional<NGLogicalOffset>& opt_leader_point) 237 const WTF::Optional<NGLogicalOffset>& opt_leader_point)
238 : constraint_space_(space) { 238 : constraint_space_(space) {
239 // TODO(chrome-layout-team): Combine exclusions that shadow each other. 239 // TODO(chrome-layout-team): Combine exclusions that shadow each other.
240 auto& exclusions = constraint_space_->Exclusions(); 240 auto& exclusions = constraint_space_->Exclusions();
241 DCHECK(std::is_sorted(exclusions->storage.begin(), exclusions->storage.end(), 241 DCHECK(std::is_sorted(exclusions->storage.begin(), exclusions->storage.end(),
242 &CompareNGExclusionsByTopAsc)) 242 &CompareNGExclusionsByTopAsc))
243 << "Exclusions are expected to be sorted by TOP"; 243 << "Exclusions are expected to be sorted by TOP";
244 244
245 NGLogicalOffset origin_point = 245 NGLogicalOffset origin_point =
(...skipping 23 matching lines...) Expand all
269 269
270 const NGLayoutOpportunity NGLayoutOpportunityIterator::Next() { 270 const NGLayoutOpportunity NGLayoutOpportunityIterator::Next() {
271 if (opportunity_iter_ == opportunities_.end()) 271 if (opportunity_iter_ == opportunities_.end())
272 return NGLayoutOpportunity(); 272 return NGLayoutOpportunity();
273 auto* opportunity = opportunity_iter_; 273 auto* opportunity = opportunity_iter_;
274 opportunity_iter_++; 274 opportunity_iter_++;
275 return NGLayoutOpportunity(*opportunity); 275 return NGLayoutOpportunity(*opportunity);
276 } 276 }
277 277
278 } // namespace blink 278 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698