Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2732113005: Revert of Turn on Ignition + TurboFan. (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Turn on Ignition + TurboFan. (patchset #2 id:20001 of https://codereview.chromium.org/2736723006/ ) Reason for revert: Collected enough test failures: http://crbug.com/698746 Original issue's description: > Turn on Ignition + TurboFan. > > _____ _ _ _ > |_ _| (_) | (_) > | | __ _ _ __ _| |_ _ ___ _ __ > | | / _` | '_ \| | __| |/ _ \| '_ \ > _| || (_| | | | | | |_| | (_) | | | | > \___/\__, |_| |_|_|\__|_|\___/|_| |_| > __/ | > |___/ > > _ > _| |_ > |_ _| > |_| > > > > _____ _ ______ > |_ _| | | | ___| > | |_ _ _ __| |__ ___ | |_ __ _ _ __ > | | | | | '__| '_ \ / _ \| _/ _` | '_ \ > | | |_| | | | |_) | (_) | || (_| | | | | > \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| > > > BUG=v8:5267, v8:4280, chromium:692409 > NOTREECHECKS=true > > Review-Url: https://codereview.chromium.org/2736723006 > Cr-Commit-Position: refs/heads/master@{#43663} > Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e6876b TBR=mstarzinger@chromium.org,danno@chromium.org,bmeurer@chromium.org,rmcilroy@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5267, v8:4280, chromium:692409 Review-Url: https://codereview.chromium.org/2732113005 Cr-Commit-Position: refs/heads/master@{#43664} Committed: https://chromium.googlesource.com/v8/v8/+/938e06f68fe9d055ee5af36e0c722856b2b60b36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Turn on Ignition + TurboFan.
3 years, 9 months ago (2017-03-08 11:46:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732113005/1
3 years, 9 months ago (2017-03-08 11:47:08 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 11:47:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/938e06f68fe9d055ee5af36e0c722856b2b...

Powered by Google App Engine
This is Rietveld 408576698