Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2736723006: Turn on Ignition + TurboFan. (Closed)

Created:
3 years, 9 months ago by mvstanton
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Original-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e6876b Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43684} Committed: https://chromium.googlesource.com/v8/v8/+/0f716acadaed1d9e194593543dbe1340d600d6fc

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 44 (24 generated)
mvstanton
Hi Michael, here is the CL we discussed...
3 years, 9 months ago (2017-03-07 15:55:14 UTC) #3
Michael Starzinger
LGTM.
3 years, 9 months ago (2017-03-07 15:57:07 UTC) #6
Michael Achenbach
lgtm - but I'd also like to get this one in: https://chromium-review.googlesource.com/c/451418/ Which could land ...
3 years, 9 months ago (2017-03-07 16:23:10 UTC) #8
mvstanton
Adding Danno, Ross and Benedikt. Danno and co., have a look?
3 years, 9 months ago (2017-03-07 17:09:51 UTC) #12
danno
lgtm. man, this has been quite a journey.
3 years, 9 months ago (2017-03-07 17:14:21 UTC) #13
Benedikt Meurer
On 2017/03/07 17:14:21, danno wrote: > lgtm. man, this has been quite a journey. LGTM, ...
3 years, 9 months ago (2017-03-07 17:32:34 UTC) #14
rmcilroy
LGTM, let's hope it doesn't Ignite the tree ;)
3 years, 9 months ago (2017-03-07 17:42:15 UTC) #15
Michael Achenbach
Landing this one which will create a merge conflict: https://chromium-review.googlesource.com/c/451418/ Please rebase on top of ...
3 years, 9 months ago (2017-03-07 17:52:12 UTC) #16
Michael Achenbach
Thanks for rebase, lgtm
3 years, 9 months ago (2017-03-07 21:33:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736723006/20001
3 years, 9 months ago (2017-03-08 08:01:42 UTC) #25
Benedikt Meurer
On 2017/03/08 08:01:42, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-08 08:02:04 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736723006/20001
3 years, 9 months ago (2017-03-08 08:09:43 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e6876b
3 years, 9 months ago (2017-03-08 08:11:05 UTC) #33
Mostyn Bramley-Moore
Can chromium:692409 be opened to non-googlers?
3 years, 9 months ago (2017-03-08 09:07:13 UTC) #34
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2732113005/ by machenbach@chromium.org. ...
3 years, 9 months ago (2017-03-08 11:46:55 UTC) #35
Michael Achenbach
Reopening this in preparation for the next try.
3 years, 9 months ago (2017-03-08 14:32:13 UTC) #37
Michael Hablich
On 2017/03/08 09:07:13, Mostyn Bramley-Moore wrote: > Can chromium:692409 be opened to non-googlers? This is ...
3 years, 9 months ago (2017-03-08 14:32:51 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2736723006/20001
3 years, 9 months ago (2017-03-09 07:16:04 UTC) #40
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/0f716acadaed1d9e194593543dbe1340d600d6fc
3 years, 9 months ago (2017-03-09 07:47:27 UTC) #43
Benedikt Meurer
3 years, 9 months ago (2017-03-09 07:48:07 UTC) #44
Message was sent while issue was closed.
Next try!

Powered by Google App Engine
This is Rietveld 408576698