|
|
DescriptionTurn on Ignition + TurboFan.
_____ _ _ _
|_ _| (_) | (_)
| | __ _ _ __ _| |_ _ ___ _ __
| | / _` | '_ \| | __| |/ _ \| '_ \
_| || (_| | | | | | |_| | (_) | | | |
\___/\__, |_| |_|_|\__|_|\___/|_| |_|
__/ |
|___/
_
_| |_
|_ _|
|_|
_____ _ ______
|_ _| | | | ___|
| |_ _ _ __| |__ ___ | |_ __ _ _ __
| | | | | '__| '_ \ / _ \| _/ _` | '_ \
| | |_| | | | |_) | (_) | || (_| | | | |
\_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_|
BUG=v8:5267, v8:4280, chromium:692409
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2736723006
Cr-Original-Commit-Position: refs/heads/master@{#43663}
Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e6876b
Review-Url: https://codereview.chromium.org/2736723006
Cr-Commit-Position: refs/heads/master@{#43684}
Committed: https://chromium.googlesource.com/v8/v8/+/0f716acadaed1d9e194593543dbe1340d600d6fc
Patch Set 1 #Patch Set 2 : REBASE. #Messages
Total messages: 44 (24 generated)
Description was changed from ========== Turn on Ignition+TurboFan. BUG= ========== to ========== Turn on Ignition+TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, chromium:692409 ==========
mvstanton@chromium.org changed reviewers: + mstarzinger@chromium.org
Hi Michael, here is the CL we discussed...
The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm - but I'd also like to get this one in: https://chromium-review.googlesource.com/c/451418/ Which could land before if wanted...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mvstanton@chromium.org changed reviewers: + bmeurer@chromium.org, danno@chromium.org, rmcilroy@chromium.org
Adding Danno, Ross and Benedikt. Danno and co., have a look?
lgtm. man, this has been quite a journey.
On 2017/03/07 17:14:21, danno wrote: > lgtm. man, this has been quite a journey. LGTM, land the fan for realz this time!!1
LGTM, let's hope it doesn't Ignite the tree ;)
Landing this one which will create a merge conflict: https://chromium-review.googlesource.com/c/451418/ Please rebase on top of it to have this CL ready. Should land in a few minutes.
Description was changed from ========== Turn on Ignition+TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, chromium:692409 ========== to ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 ==========
Thanks for rebase, lgtm
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mvstanton@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org, mstarzinger@chromium.org, danno@chromium.org, rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/2736723006/#ps20001 (title: "REBASE.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/08 08:01:42, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Woohoo!!1one
Description was changed from ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 ========== to ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488960575958680, "parent_rev": "77165eb4df97a2131349af98bffcb156b3442d42", "commit_rev": "e7f8575851a0a56ffe6772d98fd8d90602e6876b"}
Message was sent while issue was closed.
Description was changed from ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true ========== to ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e...
Message was sent while issue was closed.
Can chromium:692409 be opened to non-googlers?
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2732113005/ by machenbach@chromium.org. The reason for reverting is: Collected enough test failures: http://crbug.com/698746.
Message was sent while issue was closed.
Description was changed from ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e... ========== to ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e... ==========
Reopening this in preparation for the next try.
On 2017/03/08 09:07:13, Mostyn Bramley-Moore wrote: > Can chromium:692409 be opened to non-googlers? This is an internal tracking bug.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489043756805050, "parent_rev": "64fbb3041fe835784a7c7640d75712b39f62de18", "commit_rev": "0f716acadaed1d9e194593543dbe1340d600d6fc"}
Message was sent while issue was closed.
Description was changed from ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e... ========== to ========== Turn on Ignition + TurboFan. _____ _ _ _ |_ _| (_) | (_) | | __ _ _ __ _| |_ _ ___ _ __ | | / _` | '_ \| | __| |/ _ \| '_ \ _| || (_| | | | | | |_| | (_) | | | | \___/\__, |_| |_|_|\__|_|\___/|_| |_| __/ | |___/ _ _| |_ |_ _| |_| _____ _ ______ |_ _| | | | ___| | |_ _ _ __| |__ ___ | |_ __ _ _ __ | | | | | '__| '_ \ / _ \| _/ _` | '_ \ | | |_| | | | |_) | (_) | || (_| | | | | \_/\__,_|_| |_.__/ \___/\_| \__,_|_| |_| BUG=v8:5267, v8:4280, chromium:692409 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2736723006 Cr-Original-Commit-Position: refs/heads/master@{#43663} Committed: https://chromium.googlesource.com/v8/v8/+/e7f8575851a0a56ffe6772d98fd8d90602e... Review-Url: https://codereview.chromium.org/2736723006 Cr-Commit-Position: refs/heads/master@{#43684} Committed: https://chromium.googlesource.com/v8/v8/+/0f716acadaed1d9e194593543dbe1340d60... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/0f716acadaed1d9e194593543dbe1340d60...
Message was sent while issue was closed.
Next try! |