Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2732113004: Remove FrameHost::consoleMessageStorage() methods (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost::consoleMessageStorage() methods Remove FrameHost::consoleMessageStorage() methods, since these can now call consoleMessageStorage() directly in Page. BUG=691794 Review-Url: https://codereview.chromium.org/2732113004 Cr-Commit-Position: refs/heads/master@{#457306} Committed: https://chromium.googlesource.com/chromium/src/+/3249af70be7a33e4c48f58bf9d415dae8575a9e5

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (17 generated)
sashab
3 years, 9 months ago (2017-03-08 03:55:09 UTC) #2
joelhockey
lgtm
3 years, 9 months ago (2017-03-08 04:03:05 UTC) #3
sashab
3 years, 9 months ago (2017-03-08 04:12:55 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-08 06:06:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732113004/80001
3 years, 9 months ago (2017-03-16 01:53:09 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 01:59:52 UTC) #23
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3249af70be7a33e4c48f58bf9d41...

Powered by Google App Engine
This is Rietveld 408576698