Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2732113004: Remove FrameHost::consoleMessageStorage() methods (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All
3 * Rights Reserved. 3 * Rights Reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 } 548 }
549 549
550 void Page::didCommitLoad(LocalFrame* frame) { 550 void Page::didCommitLoad(LocalFrame* frame) {
551 if (m_mainFrame == frame) { 551 if (m_mainFrame == frame) {
552 KURL url; 552 KURL url;
553 if (frame->document()) 553 if (frame->document())
554 url = frame->document()->url(); 554 url = frame->document()->url();
555 555
556 // TODO(rbyers): Most of this doesn't appear to take into account that each 556 // TODO(rbyers): Most of this doesn't appear to take into account that each
557 // SVGImage gets it's own Page instance. 557 // SVGImage gets it's own Page instance.
558 frameHost().consoleMessageStorage().clear(); 558 consoleMessageStorage().clear();
559 useCounter().didCommitLoad(url); 559 useCounter().didCommitLoad(url);
560 deprecation().clearSuppression(); 560 deprecation().clearSuppression();
561 visualViewport().sendUMAMetrics(); 561 visualViewport().sendUMAMetrics();
562 562
563 // Need to reset visual viewport position here since before commit load we 563 // Need to reset visual viewport position here since before commit load we
564 // would update the previous history item, Page::didCommitLoad is called 564 // would update the previous history item, Page::didCommitLoad is called
565 // after a new history item is created in FrameLoader. 565 // after a new history item is created in FrameLoader.
566 // See crbug.com/642279 566 // See crbug.com/642279
567 visualViewport().setScrollOffset(ScrollOffset(), ProgrammaticScroll); 567 visualViewport().setScrollOffset(ScrollOffset(), ProgrammaticScroll);
568 m_hostsUsingFeatures.updateMeasurementsAndClear(); 568 m_hostsUsingFeatures.updateMeasurementsAndClear();
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 : chromeClient(nullptr), 644 : chromeClient(nullptr),
645 contextMenuClient(nullptr), 645 contextMenuClient(nullptr),
646 editorClient(nullptr), 646 editorClient(nullptr),
647 spellCheckerClient(nullptr) {} 647 spellCheckerClient(nullptr) {}
648 648
649 Page::PageClients::~PageClients() {} 649 Page::PageClients::~PageClients() {}
650 650
651 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 651 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
652 652
653 } // namespace blink 653 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698