Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2732023004: Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 270
271 if (enable_full_stack_frames_for_profiling) { 271 if (enable_full_stack_frames_for_profiling) {
272 cflags += [ 272 cflags += [
273 "-fno-inline", 273 "-fno-inline",
274 "-fno-optimize-sibling-calls", 274 "-fno-optimize-sibling-calls",
275 ] 275 ]
276 } 276 }
277 } 277 }
278 } 278 }
279 279
280 if (is_official_build) {
281 # Explicitly pass --build-id to ld. Compilers used to always pass this
282 # implicitly but don't any more (in particular clang when built without
283 # ENABLE_LINKER_BUILD_ID=ON). The crash infrastructure does need a build
284 # id, so explicitly enable it in official builds. It's not needed in
285 # unofficial builds and computing it does slow down the link, so go with
286 # faster links in unofficial builds.
287 ldflags += [ "-Wl,--build-id=sha1" ]
288 }
289
290 defines += [ "_FILE_OFFSET_BITS=64" ] 280 defines += [ "_FILE_OFFSET_BITS=64" ]
291 281
292 if (!is_android) { 282 if (!is_android) {
293 defines += [ 283 defines += [
294 "_LARGEFILE_SOURCE", 284 "_LARGEFILE_SOURCE",
295 "_LARGEFILE64_SOURCE", 285 "_LARGEFILE64_SOURCE",
296 ] 286 ]
297 } 287 }
298 288
299 if (!is_nacl) { 289 if (!is_nacl) {
(...skipping 1416 matching lines...) Expand 10 before | Expand all | Expand 10 after
1716 1706
1717 if (is_ios || is_mac) { 1707 if (is_ios || is_mac) {
1718 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1708 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1719 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1709 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1720 config("enable_arc") { 1710 config("enable_arc") {
1721 common_flags = [ "-fobjc-arc" ] 1711 common_flags = [ "-fobjc-arc" ]
1722 cflags_objc = common_flags 1712 cflags_objc = common_flags
1723 cflags_objcc = common_flags 1713 cflags_objcc = common_flags
1724 } 1714 }
1725 } 1715 }
OLDNEW
« no previous file with comments | « build/config/android/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698