Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Issue 2731753003: precompiled_header has no effect for GCC-style PCH, don't set it. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

precompiled_header has no effect for GCC-style PCH, don't set it. No intended behavior change. BUG=none Review-Url: https://codereview.chromium.org/2731753003 Cr-Commit-Position: refs/heads/master@{#454923} Committed: https://chromium.googlesource.com/chromium/src/+/9d6d06986b7ad2e33f294710d170f78108060790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
3 years, 9 months ago (2017-03-03 20:29:49 UTC) #3
brettw
lgtm
3 years, 9 months ago (2017-03-06 18:05:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731753003/1
3 years, 9 months ago (2017-03-06 18:21:15 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 19:48:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d6d06986b7ad2e33f294710d170...

Powered by Google App Engine
This is Rietveld 408576698