Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: build/config/BUILD.gn

Issue 2731753003: precompiled_header has no effect for GCC-style PCH, don't set it. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/features.gni") 10 import("//build/config/features.gni")
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 # 385 #
386 # This error doesn't happen every time. In VS2013, it seems if the .pch 386 # This error doesn't happen every time. In VS2013, it seems if the .pch
387 # file doesn't exist, no error will be generated (probably MS tested this 387 # file doesn't exist, no error will be generated (probably MS tested this
388 # case but forgot the other one?). To reproduce this error, do a build, 388 # case but forgot the other one?). To reproduce this error, do a build,
389 # then delete the precompile.c.obj file, then build again. 389 # then delete the precompile.c.obj file, then build again.
390 # 390 #
391 # TODO(sof): determine VS2015 status and retire the setting from all 391 # TODO(sof): determine VS2015 status and retire the setting from all
392 # precompiled configurations. 392 # precompiled configurations.
393 cflags_c = [ "/wd4206" ] 393 cflags_c = [ "/wd4206" ]
394 } else if (is_mac) { 394 } else if (is_mac) {
395 precompiled_header = "build/precompile.h"
396 precompiled_source = "//build/precompile.h" 395 precompiled_source = "//build/precompile.h"
397 } 396 }
398 } 397 }
399 } 398 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698