[eme] Ignore capabilities with unrecognized parameters

[eme] Ignore capabilities with unrecognized parameters

The EME spec notes that if "the user agent does not recognize one or more
parameters" in a capability, skip over it. So if additional parameters are
present, the capability should be ignored.

BUG=487392, 690131
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2731743003
Cr-Commit-Position: refs/heads/master@{#455230}
Committed: https://chromium.googlesource.com/chromium/src/+/59882b5e4f6cdfbaa6b818a29de7212eb8abbf4c

[jrummell, 2017-03-03 23:05:31]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2017-03-03 23:05:31]

PTAL. Another small change.

[xhwang, 2017-03-03 23:20:58]

Thanks! I only have a few minor comment. Also there are a few typo/errors in the
CL description.

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
(right):

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html:328:
}], 'NotSupportedError', 'contentType video/fake');
Also add a test with additional paramters in contentType?

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
(right):

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:56:
// Fail if there are unrecognized parameters. There is no way to
"Fail" isn't accurate since we just skip it..

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:56:
// Fail if there are unrecognized parameters. There is no way to
Please quote the spec here:

"If the user agent does not recognize one or more parameters" in a capability,
skip over it etc

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:58:
// parameter is available. Chromium expects "codecs" to be valid, so
ooc, what if we have two "codecs" parameters?

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:59:
// this capability will fail if codecs not the only parameter specified.
again, s/fail/skip, also s/not/is not/

[jrummell, 2017-03-03 23:34:09]

Description was changed from

==========
[eme] Ignore capabilities with unrecognized parameters

The EME spec notes that if "If the user agent does not recognize one or more
parameters" in a capability, skip over it. So if additional parameters are
present, the capability should be ignored.

BUG=487392,690131
TEST=new tests pass
==========

to

==========
[eme] Ignore capabilities with unrecognized parameters

The EME spec notes that if "the user agent does not recognize one or more
parameters" in a capability, skip over it. So if additional parameters are
present, the capability should be ignored.

BUG=487392,690131
TEST=new tests pass
==========

[jrummell, 2017-03-04 00:48:26]

Updated.

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
(right):

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html:328:
}], 'NotSupportedError', 'contentType video/fake');
On 2017/03/03 23:20:57, xhwang_slow wrote:
> Also add a test with additional paramters in contentType?

I think this is tested in the tests above.

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
(right):

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:56:
// Fail if there are unrecognized parameters. There is no way to
On 2017/03/03 23:20:58, xhwang_slow wrote:
> Please quote the spec here:
> 
> "If the user agent does not recognize one or more parameters" in a capability,
> skip over it etc

Done.

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:56:
// Fail if there are unrecognized parameters. There is no way to
On 2017/03/03 23:20:58, xhwang_slow wrote:
> "Fail" isn't accurate since we just skip it..

Removed.

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:58:
// parameter is available. Chromium expects "codecs" to be valid, so
On 2017/03/03 23:20:58, xhwang_slow wrote:
> ooc, what if we have two "codecs" parameters? 

ParsedContentType only returns the last one, so it would appear to have only 1
parameter. Opened http://crbug.com/698436.

https://codereview.chromium.org/2731743003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp:59:
// this capability will fail if codecs not the only parameter specified.
On 2017/03/03 23:20:58, xhwang_slow wrote:
> again, s/fail/skip, also s/not/is not/

Done.

[xhwang, 2017-03-04 05:19:37]

Thanks! lgtm

[jrummell, 2017-03-06 23:32:02]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:59:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jrummell, 2017-03-07 19:55:15]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2017-03-07 19:56:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 21:50:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488916515801760,
"parent_rev": "d02a1d189e60d72da5511ec2620a1ff89d642cf8", "commit_rev":
"59882b5e4f6cdfbaa6b818a29de7212eb8abbf4c"}

[commit-bot: I haz the power, 2017-03-07 21:51:01]

Description was changed from

==========
[eme] Ignore capabilities with unrecognized parameters

The EME spec notes that if "the user agent does not recognize one or more
parameters" in a capability, skip over it. So if additional parameters are
present, the capability should be ignored.

BUG=487392,690131
TEST=new tests pass
==========

to

==========
[eme] Ignore capabilities with unrecognized parameters

The EME spec notes that if "the user agent does not recognize one or more
parameters" in a capability, skip over it. So if additional parameters are
present, the capability should be ignored.

BUG=487392,690131
TEST=new tests pass

Review-Url: https://codereview.chromium.org/2731743003
Cr-Commit-Position: refs/heads/master@{#455230}
Committed:
https://chromium.googlesource.com/chromium/src/+/59882b5e4f6cdfbaa6b818a29de7...
==========

[commit-bot: I haz the power, 2017-03-07 21:51:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59882b5e4f6cdfbaa6b818a29de7...