Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html

Issue 2731743003: [eme] Ignore capabilities with unrecognized parameters (Closed)
Patch Set: improve comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
diff --git a/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html b/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
index 1854efb60e4093504b8c1da47f05ae42b80fa669..23285980717641c9a148c5a2d99930f2f8011e3f 100644
--- a/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
+++ b/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html
@@ -251,13 +251,11 @@
videoCapabilities: [{contentType: 'video/webm; codecs="vp8"'}],
}, 'Extra spaces after ; in contentType');
- // TODO(jrummell): contentType should allow white space at the
- // end of the string. http://crbug.com/487392
-// expect_config('org.w3.clearkey', [{
-// videoCapabilities: [{contentType: 'video/webm; codecs="vp8" '}],
-// }], {
-// videoCapabilities: [{contentType: 'video/webm; codecs="vp8" '}],
-// }, 'Trailing space in contentType');
+ expect_config('org.w3.clearkey', [{
+ videoCapabilities: [{contentType: 'video/webm; codecs="vp8" '}],
+ }], {
+ videoCapabilities: [{contentType: 'video/webm; codecs="vp8" '}],
+ }, 'Trailing space in contentType');
expect_config('org.w3.clearkey', [{
videoCapabilities: [{contentType: 'video/webm; codecs=" vp8"'}],
@@ -309,14 +307,12 @@
}], 'NotSupportedError', 'Codec is case-sensitive');
// Unrecognized attributes are not allowed.
- // TODO(jrummell): Unrecognized attributes are ignored currently.
- // http://crbug.com/690131
-// expect_error('org.w3.clearkey', [{
-// videoCapabilities: [{contentType: 'video/webm; foo="bar"'}],
-// }], 'NotSupportedError', 'Unrecognized foo');
-// expect_error('org.w3.clearkey', [{
-// videoCapabilities: [{contentType: 'video/webm; foo="bar"; codecs="vp8"'}],
-// }], 'NotSupportedError', 'Unrecognized foo with codecs');
+ expect_error('org.w3.clearkey', [{
+ videoCapabilities: [{contentType: 'video/webm; foo="bar"'}],
+ }], 'NotSupportedError', 'Unrecognized foo');
+ expect_error('org.w3.clearkey', [{
+ videoCapabilities: [{contentType: 'video/webm; foo="bar"; codecs="vp8"'}],
+ }], 'NotSupportedError', 'Unrecognized foo with codecs');
// Invalid contentTypes.
expect_error('org.w3.clearkey', [{
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698