Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2731403011: Add Mac10.12 builders to list of supported Blink builders. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Mac10.12 builders to list of supported Blink builders. After this is added, Mac10.12 builders will be used when getting new baselines (rebaseline-o-matic and rebaseline-cl), and and will be checked when removing flaky expectations (update-test-expectations). I believe that https://codereview.chromium.org/2738053002 should be committed first. BUG=697971 Review-Url: https://codereview.chromium.org/2731403011 Cr-Commit-Position: refs/heads/master@{#455767} Committed: https://chromium.googlesource.com/chromium/src/+/f28225ec53772397fd733419aae63268b8219fdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 9 months ago (2017-03-08 23:59:29 UTC) #5
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-09 01:39:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731403011/1
3 years, 9 months ago (2017-03-09 16:35:40 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:43:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f28225ec53772397fd733419aae6...

Powered by Google App Engine
This is Rietveld 408576698