Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2738053002: Add Mac10.12 to Port.ALL_SYSTEMS and Port.CONFIGURATION_SPECIFIER_MACROS. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent, Dirk Pranke
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mac10.12 to Port.ALL_SYSTEMS and Port.CONFIGURATION_SPECIFIER_MACROS. BUG=699767, 697971 Review-Url: https://codereview.chromium.org/2738053002 Cr-Commit-Position: refs/heads/master@{#455626} Committed: https://chromium.googlesource.com/chromium/src/+/334f3cfa4383af5f17c35e0f23ee7485f37136ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
qyearsley
3 years, 9 months ago (2017-03-08 23:59:30 UTC) #4
tkent
lgtm
3 years, 9 months ago (2017-03-09 00:09:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738053002/1
3 years, 9 months ago (2017-03-09 00:10:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/334f3cfa4383af5f17c35e0f23ee7485f37136ff
3 years, 9 months ago (2017-03-09 01:37:12 UTC) #11
Dirk Pranke
Do you need to adjust the fallback paths as well somewhere?
3 years, 9 months ago (2017-03-09 01:40:36 UTC) #13
tkent
On 2017/03/09 at 01:40:36, dpranke wrote: > Do you need to adjust the fallback paths ...
3 years, 9 months ago (2017-03-09 02:10:46 UTC) #14
Dirk Pranke
3 years, 9 months ago (2017-03-09 02:26:35 UTC) #15
Message was sent while issue was closed.
On 2017/03/09 02:10:46, tkent wrote:
> On 2017/03/09 at 01:40:36, dpranke wrote:
> > Do you need to adjust the fallback paths as well somewhere?
> 
> It seems we already have it in port/mac.py.

Ah, yes, it was added in #454777 (on Saturday).

Powered by Google App Engine
This is Rietveld 408576698