Add headless chrome as an accepted browser string in chromedriver.

Add headless chrome as an accepted browser string in chromedriver.

This is working towards selenium support for headless see https://bugs.chromium.org/p/chromium/issues/detail?id=604324

BUG=699382, 604324
Review-Url: https://codereview.chromium.org/2731403008
Cr-Commit-Position: refs/heads/master@{#456660}
Committed: https://chromium.googlesource.com/chromium/src/+/c75dbfd25cc376b92a494d340259056a01e1432e

[irisu, 2017-03-08 05:08:06]

Description was changed from

==========
Add headless chrome as an accepted browser string in chromedriver.

BUG=699382
==========

to

==========
Add headless chrome as an accepted browser string in chromedriver.

BUG=699382,604324
==========

[irisu, 2017-03-08 05:11:14]

Description was changed from

==========
Add headless chrome as an accepted browser string in chromedriver.

BUG=699382,604324
==========

to

==========
Add headless chrome as an accepted browser string in chromedriver.

This is working towards selenium support for headless see
https://bugs.chromium.org/p/chromium/issues/detail?id=604324

BUG=699382,604324
==========

[irisu, 2017-03-08 05:11:21]

irisu@chromium.org changed reviewers:
+ samuong@chromium.org

[samuong, 2017-03-08 21:24:15]

https://codereview.chromium.org/2731403008/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/browser_info.cc (right):

https://codereview.chromium.org/2731403008/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/browser_info.cc:93: if
(base::StartsWith(browser_string, kVersionPrefix,
Can we merge these two if blocks somehow? I'm thinking we could replace the call
to base::StartsWith here with std::string::find. And then check
StartsWith(kHeadlessVersionPrefix) when we set |browser_name|. WDYT?

I'm assuming that both Chrome and HeadlessChrome have the same version scheme,
but if that's not the case then we probably shouldn't do it the way I suggested.

[irisu, 2017-03-08 23:49:34]

https://codereview.chromium.org/2731403008/diff/1/chrome/test/chromedriver/ch...
File chrome/test/chromedriver/chrome/browser_info.cc (right):

https://codereview.chromium.org/2731403008/diff/1/chrome/test/chromedriver/ch...
chrome/test/chromedriver/chrome/browser_info.cc:93: if
(base::StartsWith(browser_string, kVersionPrefix,
On 2017/03/08 21:24:15, samuong wrote:
> Can we merge these two if blocks somehow? I'm thinking we could replace the
call
> to base::StartsWith here with std::string::find. And then check
> StartsWith(kHeadlessVersionPrefix) when we set |browser_name|. WDYT?
> 
> I'm assuming that both Chrome and HeadlessChrome have the same version scheme,
> but if that's not the case then we probably shouldn't do it the way I
suggested.

Done.

[samuong, 2017-03-10 00:07:13]

lgtm

[irisu, 2017-03-10 00:33:21]

The CQ bit was checked by irisu@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:33:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 00:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:45:40]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[irisu, 2017-03-10 01:41:31]

Fixed tests and added a headless test. PTAL.

[irisu, 2017-03-14 09:21:33]

The CQ bit was checked by irisu@chromium.org

[irisu, 2017-03-14 09:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from samuong@chromium.org
Link to the patchset: https://codereview.chromium.org/2731403008/#ps30001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-03-14 09:21:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 09:34:45]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1489483293459770,
"parent_rev": "008c85e4011f9a860f94df75c3bd69c7aece6bab", "commit_rev":
"c75dbfd25cc376b92a494d340259056a01e1432e"}

[commit-bot: I haz the power, 2017-03-14 09:35:25]

Description was changed from

==========
Add headless chrome as an accepted browser string in chromedriver.

This is working towards selenium support for headless see
https://bugs.chromium.org/p/chromium/issues/detail?id=604324

BUG=699382,604324
==========

to

==========
Add headless chrome as an accepted browser string in chromedriver.

This is working towards selenium support for headless see
https://bugs.chromium.org/p/chromium/issues/detail?id=604324

BUG=699382,604324

Review-Url: https://codereview.chromium.org/2731403008
Cr-Commit-Position: refs/heads/master@{#456660}
Committed:
https://chromium.googlesource.com/chromium/src/+/c75dbfd25cc376b92a494d340259...
==========

[commit-bot: I haz the power, 2017-03-14 09:35:27]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/c75dbfd25cc376b92a494d340259...