Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/test/chromedriver/chrome/browser_info.cc

Issue 2731403008: Add headless chrome as an accepted browser string in chromedriver. (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/browser_info_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/chrome/browser_info.h" 5 #include "chrome/test/chromedriver/chrome/browser_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "base/json/json_reader.h" 11 #include "base/json/json_reader.h"
12 #include "base/strings/string_number_conversions.h" 12 #include "base/strings/string_number_conversions.h"
13 #include "base/strings/string_split.h" 13 #include "base/strings/string_split.h"
14 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
15 #include "base/values.h" 15 #include "base/values.h"
16 16
17 namespace { 17 namespace {
18 18
19 const char kVersionPrefix[] = "Chrome/"; 19 const char kVersionPrefix[] = "Chrome/";
20 const size_t kVersionPrefixLen = sizeof(kVersionPrefix) - 1; 20 const size_t kVersionPrefixLen = sizeof(kVersionPrefix) - 1;
21 21
22 const char kHeadlessVersionPrefix[] = "HeadlessChrome/";
23 const size_t kHeadlessVersionPrefixLen = sizeof(kHeadlessVersionPrefix) - 1;
24
22 } // namespace 25 } // namespace
23 26
24 BrowserInfo::BrowserInfo() 27 BrowserInfo::BrowserInfo()
25 : major_version(0), 28 : major_version(0),
26 build_no(kToTBuildNo), 29 build_no(kToTBuildNo),
27 blink_revision(kToTBlinkRevision), 30 blink_revision(kToTBlinkRevision),
28 is_android(false) { 31 is_android(false) {
29 } 32 }
30 33
31 BrowserInfo::BrowserInfo(std::string android_package, 34 BrowserInfo::BrowserInfo(std::string android_package,
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 const std::string& browser_string, 82 const std::string& browser_string,
80 BrowserInfo* browser_info) { 83 BrowserInfo* browser_info) {
81 if (has_android_package) 84 if (has_android_package)
82 browser_info->is_android = true; 85 browser_info->is_android = true;
83 86
84 if (browser_string.empty()) { 87 if (browser_string.empty()) {
85 browser_info->browser_name = "content shell"; 88 browser_info->browser_name = "content shell";
86 return Status(kOk); 89 return Status(kOk);
87 } 90 }
88 91
92 const Status error =
93 Status(kUnknownError, "unrecognized Chrome version: " + browser_string);
94
89 int build_no = 0; 95 int build_no = 0;
90 if (base::StartsWith(browser_string, kVersionPrefix, 96 if (base::StartsWith(browser_string, kVersionPrefix,
97 base::CompareCase::SENSITIVE) ||
98 base::StartsWith(browser_string, kHeadlessVersionPrefix,
91 base::CompareCase::SENSITIVE)) { 99 base::CompareCase::SENSITIVE)) {
92 std::string version = browser_string.substr(kVersionPrefixLen); 100 std::string version = browser_string.substr(kVersionPrefixLen);
101 bool headless = false;
102 if (base::StartsWith(browser_string, kHeadlessVersionPrefix,
103 base::CompareCase::SENSITIVE)) {
104 version = browser_string.substr(kHeadlessVersionPrefixLen);
105 headless = true;
106 }
93 107
94 Status status = ParseBrowserVersionString( 108 Status status = ParseBrowserVersionString(
95 version, &browser_info->major_version, &build_no); 109 version, &browser_info->major_version, &build_no);
96 if (status.IsError()) 110 if (status.IsError())
97 return status; 111 return status;
98 112
99 if (build_no != 0) { 113 if (build_no != 0) {
100 browser_info->browser_name = "chrome"; 114 if (headless)
115 browser_info->browser_name = "headless chrome";
116 else
117 browser_info->browser_name = "chrome";
101 browser_info->browser_version = version; 118 browser_info->browser_version = version;
102 browser_info->build_no = build_no; 119 browser_info->build_no = build_no;
103 return Status(kOk); 120 return Status(kOk);
104 } 121 }
105 } 122 }
106 123
107 if (browser_string.find("Version/") == 0u || // KitKat 124 if (browser_string.find("Version/") == 0u || // KitKat
108 (has_android_package && build_no == 0)) { // Lollipop 125 (has_android_package && build_no == 0)) { // Lollipop
109 size_t pos = browser_string.find(kVersionPrefix); 126 size_t pos = browser_string.find(kVersionPrefix);
110 if (pos != std::string::npos) { 127 if (pos != std::string::npos) {
111 browser_info->browser_name = "webview"; 128 browser_info->browser_name = "webview";
112 browser_info->browser_version = 129 browser_info->browser_version =
113 browser_string.substr(pos + kVersionPrefixLen); 130 browser_string.substr(pos + kVersionPrefixLen);
114 browser_info->is_android = true; 131 browser_info->is_android = true;
115 return ParseBrowserVersionString(browser_info->browser_version, 132 return ParseBrowserVersionString(browser_info->browser_version,
116 &browser_info->major_version, &build_no); 133 &browser_info->major_version, &build_no);
117 } 134 }
118 return Status(kOk); 135 return Status(kOk);
119 } 136 }
120 137
121 return Status(kUnknownError, 138 return error;
122 "unrecognized Chrome version: " + browser_string);
123 } 139 }
124 140
125 Status ParseBrowserVersionString(const std::string& browser_version, 141 Status ParseBrowserVersionString(const std::string& browser_version,
126 int* major_version, int* build_no) { 142 int* major_version, int* build_no) {
127 std::vector<base::StringPiece> version_parts = base::SplitStringPiece( 143 std::vector<base::StringPiece> version_parts = base::SplitStringPiece(
128 browser_version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); 144 browser_version, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
129 if (version_parts.size() != 4 || 145 if (version_parts.size() != 4 ||
130 !base::StringToInt(version_parts[0], major_version) || 146 !base::StringToInt(version_parts[0], major_version) ||
131 !base::StringToInt(version_parts[2], build_no)) { 147 !base::StringToInt(version_parts[2], build_no)) {
132 return Status(kUnknownError, 148 return Status(kUnknownError,
(...skipping 23 matching lines...) Expand all
156 return Status(kOk); 172 return Status(kOk);
157 } 173 }
158 174
159 bool IsGitHash(const std::string& revision) { 175 bool IsGitHash(const std::string& revision) {
160 const int kShortGitHashLength = 7; 176 const int kShortGitHashLength = 7;
161 const int kFullGitHashLength = 40; 177 const int kFullGitHashLength = 40;
162 return kShortGitHashLength <= revision.size() 178 return kShortGitHashLength <= revision.size()
163 && revision.size() <= kFullGitHashLength 179 && revision.size() <= kFullGitHashLength
164 && base::ContainsOnlyChars(revision, "0123456789abcdefABCDEF"); 180 && base::ContainsOnlyChars(revision, "0123456789abcdefABCDEF");
165 } 181 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/browser_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698