Use EphemeralRange to construct StaticRange

Use EphemeralRange to construct StaticRange

This CL:
  1. Added |StaticRange::create(EphemeralRange)|.
  2. Replace the useage of |Range| with |EphemeralRange|.

BUG=692700
Review-Url: https://codereview.chromium.org/2731393004
Cr-Commit-Position: refs/heads/master@{#456710}
Committed: https://chromium.googlesource.com/chromium/src/+/cab49d129c5ef30fe8dd4abe3013bccbd8df74d1

[chongz, 2017-03-07 22:13:46]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 22:14:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 00:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:22:42]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-03-08 02:56:10]

Description was changed from

==========
Use EphemeralRange instead of Range

BUG=692700
==========

to

==========
Use EphemeralRange to construct StaticRange

This CL:
  1. Added |StaticRange::create(EphemeralRange)|.
  2. Replace the useage of |Range| with |EphemeralRange|.

BUG=692700
==========

[chongz, 2017-03-08 02:56:40]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-03-08 02:56:41]

yosin@ PTAL, thanks!

[yosin_UTC9, 2017-03-08 07:35:51]

lgtm w/ nits

Thanks for quick work! (^_^)b

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StaticRange.h (right):

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StaticRange.h:43: return new
StaticRange(range.document(),
Let's add |DCHECK(!range.isNull());| since creating StaticRange with empty range
is wrong.

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:2095: EphemeralRange
range =
nit: s/EphmeralRange/const EphemeralRange&/
to avoid copy.

[chongz, 2017-03-08 15:59:12]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 15:59:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 17:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 17:51:10]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-03-08 18:31:08]

chongz@chromium.org changed reviewers:
+ ojan@chromium.org

[chongz, 2017-03-08 18:31:09]

ojan@ PTAL at "StaticRange.h", thanks!

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StaticRange.h (right):

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StaticRange.h:43: return new
StaticRange(range.document(),
On 2017/03/08 07:35:51, yosin_UTC9 wrote:
> Let's add |DCHECK(!range.isNull());| since creating StaticRange with empty
range
> is wrong.

Done.

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:2095: EphemeralRange
range =
On 2017/03/08 07:35:51, yosin_UTC9 wrote:
> nit: s/EphmeralRange/const EphemeralRange&/
> to avoid copy.

Done.

[chongz, 2017-03-14 08:18:36]

chongz@chromium.org changed reviewers:
+ tkent@chromium.org
- ojan@chromium.org

[chongz, 2017-03-14 08:18:36]

tkent@ PTAL at "StaticRange.h", thanks! (It seems that ojan@ is not available)

[tkent, 2017-03-14 08:26:56]

lgtm

[chongz, 2017-03-14 13:58:27]

The CQ bit was checked by chongz@chromium.org

[chongz, 2017-03-14 13:58:27]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2731393004/#ps20001
(title: "yosin's review: Fix nits")

[commit-bot: I haz the power, 2017-03-14 13:58:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 15:46:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489499907176470,
"parent_rev": "6f78a7a80b37afd562cd45f57c1b9a4a3ff711e1", "commit_rev":
"cab49d129c5ef30fe8dd4abe3013bccbd8df74d1"}

[commit-bot: I haz the power, 2017-03-14 15:47:31]

Description was changed from

==========
Use EphemeralRange to construct StaticRange

This CL:
  1. Added |StaticRange::create(EphemeralRange)|.
  2. Replace the useage of |Range| with |EphemeralRange|.

BUG=692700
==========

to

==========
Use EphemeralRange to construct StaticRange

This CL:
  1. Added |StaticRange::create(EphemeralRange)|.
  2. Replace the useage of |Range| with |EphemeralRange|.

BUG=692700

Review-Url: https://codereview.chromium.org/2731393004
Cr-Commit-Position: refs/heads/master@{#456710}
Committed:
https://chromium.googlesource.com/chromium/src/+/cab49d129c5ef30fe8dd4abe3013...
==========

[commit-bot: I haz the power, 2017-03-14 15:47:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cab49d129c5ef30fe8dd4abe3013...