Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2731393004: Use EphemeralRange to construct StaticRange (Closed)

Created:
3 years, 9 months ago by chongz
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EphemeralRange to construct StaticRange This CL: 1. Added |StaticRange::create(EphemeralRange)|. 2. Replace the useage of |Range| with |EphemeralRange|. BUG=692700 Review-Url: https://codereview.chromium.org/2731393004 Cr-Commit-Position: refs/heads/master@{#456710} Committed: https://chromium.googlesource.com/chromium/src/+/cab49d129c5ef30fe8dd4abe3013bccbd8df74d1

Patch Set 1 #

Total comments: 4

Patch Set 2 : yosin's review: Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/StaticRange.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
chongz
yosin@ PTAL, thanks!
3 years, 9 months ago (2017-03-08 02:56:41 UTC) #7
yosin_UTC9
lgtm w/ nits Thanks for quick work! (^_^)b https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/core/dom/StaticRange.h File third_party/WebKit/Source/core/dom/StaticRange.h (right): https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/core/dom/StaticRange.h#newcode43 third_party/WebKit/Source/core/dom/StaticRange.h:43: return ...
3 years, 9 months ago (2017-03-08 07:35:51 UTC) #8
chongz
ojan@ PTAL at "StaticRange.h", thanks! https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/core/dom/StaticRange.h File third_party/WebKit/Source/core/dom/StaticRange.h (right): https://codereview.chromium.org/2731393004/diff/1/third_party/WebKit/Source/core/dom/StaticRange.h#newcode43 third_party/WebKit/Source/core/dom/StaticRange.h:43: return new StaticRange(range.document(), On ...
3 years, 9 months ago (2017-03-08 18:31:09 UTC) #14
chongz
tkent@ PTAL at "StaticRange.h", thanks! (It seems that ojan@ is not available)
3 years, 9 months ago (2017-03-14 08:18:36 UTC) #16
tkent
lgtm
3 years, 9 months ago (2017-03-14 08:26:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731393004/20001
3 years, 9 months ago (2017-03-14 13:58:48 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 15:47:33 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cab49d129c5ef30fe8dd4abe3013...

Powered by Google App Engine
This is Rietveld 408576698