third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2731393004: Use EphemeralRange to construct StaticRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2731393004: Use EphemeralRange to construct StaticRange (Closed)

Patch Set: yosin's review: Fix nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index 478c8b7fccde663f9bbb365f8b1a32b4f2aac3e0..a24abd61e01b70a34d877344a44a83b2f66c1fb1 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -206,7 +206,7 @@ StaticRangeVector* RangesFromCurrentSelectionOrExtendCaret(

if (selectionModifier.selection().isNone())

return ranges;

ranges->push_back(StaticRange::create(

- createRange(firstEphemeralRangeOf(selectionModifier.selection()))));

+ firstEphemeralRangeOf(selectionModifier.selection())));

return ranges;

}

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | no next file » | no next file with comments »